From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg KH) Date: Tue, 12 May 2015 15:42:16 -0700 Subject: [PATCH v3] dma-buf: add ref counting for module as exporter In-Reply-To: <1431092563-19799-1-git-send-email-sumit.semwal@linaro.org> References: <1431092563-19799-1-git-send-email-sumit.semwal@linaro.org> Message-ID: <20150512224216.GA16712@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, May 08, 2015 at 07:12:43PM +0530, Sumit Semwal wrote: > Add reference counting on a kernel module that exports dma-buf and > implements its operations. This prevents the module from being unloaded > while DMABUF file is in use. > > The original patch [1] was submitted by Tomasz Stanislawski, but this > is a simpler way to do it. > > v3: call module_put() as late as possible, per gregkh's comment. > v2: move owner to struct dma_buf, and use DEFINE_DMA_BUF_EXPORT_INFO > macro to simplify the change. > > Signed-off-by: Sumit Semwal > > [1]: https://lkml.org/lkml/2012/8/8/163 > --- > drivers/dma-buf/dma-buf.c | 10 +++++++++- > include/linux/dma-buf.h | 10 ++++++++-- > 2 files changed, 17 insertions(+), 3 deletions(-) Acked-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v3] dma-buf: add ref counting for module as exporter Date: Tue, 12 May 2015 15:42:16 -0700 Message-ID: <20150512224216.GA16712@kroah.com> References: <1431092563-19799-1-git-send-email-sumit.semwal@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by gabe.freedesktop.org (Postfix) with ESMTP id 309BA6E33E for ; Tue, 12 May 2015 15:42:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1431092563-19799-1-git-send-email-sumit.semwal@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sumit Semwal Cc: linaro-kernel@lists.linaro.org, pawel@osciak.com, mchehab@osg.samsung.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, kgene@kernel.org, rmk+kernel@arm.linux.org.uk, m.szyprowski@samsung.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBNYXkgMDgsIDIwMTUgYXQgMDc6MTI6NDNQTSArMDUzMCwgU3VtaXQgU2Vtd2FsIHdy b3RlOgo+IEFkZCByZWZlcmVuY2UgY291bnRpbmcgb24gYSBrZXJuZWwgbW9kdWxlIHRoYXQgZXhw b3J0cyBkbWEtYnVmIGFuZAo+IGltcGxlbWVudHMgaXRzIG9wZXJhdGlvbnMuIFRoaXMgcHJldmVu dHMgdGhlIG1vZHVsZSBmcm9tIGJlaW5nIHVubG9hZGVkCj4gd2hpbGUgRE1BQlVGIGZpbGUgaXMg aW4gdXNlLgo+IAo+IFRoZSBvcmlnaW5hbCBwYXRjaCBbMV0gd2FzIHN1Ym1pdHRlZCBieSBUb21h c3ogU3RhbmlzbGF3c2tpLCBidXQgdGhpcwo+IGlzIGEgc2ltcGxlciB3YXkgdG8gZG8gaXQuCj4g Cj4gdjM6IGNhbGwgbW9kdWxlX3B1dCgpIGFzIGxhdGUgYXMgcG9zc2libGUsIHBlciBncmVna2gn cyBjb21tZW50Lgo+IHYyOiBtb3ZlIG93bmVyIHRvIHN0cnVjdCBkbWFfYnVmLCBhbmQgdXNlIERF RklORV9ETUFfQlVGX0VYUE9SVF9JTkZPCj4gICAgIG1hY3JvIHRvIHNpbXBsaWZ5IHRoZSBjaGFu Z2UuCj4gCj4gU2lnbmVkLW9mZi1ieTogU3VtaXQgU2Vtd2FsIDxzdW1pdC5zZW13YWxAbGluYXJv Lm9yZz4KPiAKPiBbMV06IGh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDEyLzgvOC8xNjMKPiAtLS0K PiAgZHJpdmVycy9kbWEtYnVmL2RtYS1idWYuYyB8IDEwICsrKysrKysrKy0KPiAgaW5jbHVkZS9s aW51eC9kbWEtYnVmLmggICB8IDEwICsrKysrKysrLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxNyBp bnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKQWNrZWQtYnk6IEdyZWcgS3JvYWgtSGFydG1h biA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+Cl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:33785 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933868AbbELWmR (ORCPT ); Tue, 12 May 2015 18:42:17 -0400 Date: Tue, 12 May 2015 15:42:16 -0700 From: Greg KH To: Sumit Semwal Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arm-kernel@lists.infradead.org, rmk+kernel@arm.linux.org.uk, airlied@linux.ie, kgene@kernel.org, thierry.reding@gmail.com, pawel@osciak.com, m.szyprowski@samsung.com, mchehab@osg.samsung.com, linaro-kernel@lists.linaro.org, robdclark@gmail.com, daniel@ffwll.ch Subject: Re: [PATCH v3] dma-buf: add ref counting for module as exporter Message-ID: <20150512224216.GA16712@kroah.com> References: <1431092563-19799-1-git-send-email-sumit.semwal@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431092563-19799-1-git-send-email-sumit.semwal@linaro.org> Sender: linux-media-owner@vger.kernel.org List-ID: On Fri, May 08, 2015 at 07:12:43PM +0530, Sumit Semwal wrote: > Add reference counting on a kernel module that exports dma-buf and > implements its operations. This prevents the module from being unloaded > while DMABUF file is in use. > > The original patch [1] was submitted by Tomasz Stanislawski, but this > is a simpler way to do it. > > v3: call module_put() as late as possible, per gregkh's comment. > v2: move owner to struct dma_buf, and use DEFINE_DMA_BUF_EXPORT_INFO > macro to simplify the change. > > Signed-off-by: Sumit Semwal > > [1]: https://lkml.org/lkml/2012/8/8/163 > --- > drivers/dma-buf/dma-buf.c | 10 +++++++++- > include/linux/dma-buf.h | 10 ++++++++-- > 2 files changed, 17 insertions(+), 3 deletions(-) Acked-by: Greg Kroah-Hartman