From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] powerpc-utils: optionally use librtas
Date: Wed, 13 May 2015 06:16:17 +0300 [thread overview]
Message-ID: <20150513031617.GD2558@tarshish> (raw)
In-Reply-To: <4a40d63bb8a0fdf9a3dc8811a62dc7872fcddd87.1431403924.git.sam.bobroff@au1.ibm.com>
Hi Sam,
On Tue, May 12, 2015 at 02:12:08PM +1000, Sam Bobroff wrote:
> diff --git a/package/powerpc-utils/powerpc-utils.mk b/package/powerpc-utils/powerpc-utils.mk
> index 3b30458..486ed20 100644
> --- a/package/powerpc-utils/powerpc-utils.mk
> +++ b/package/powerpc-utils/powerpc-utils.mk
> @@ -7,10 +7,15 @@
> POWERPC_UTILS_VERSION = 1.2.24
> POWERPC_UTILS_SITE = http://downloads.sourceforge.net/project/powerpc-utils/powerpc-utils
> POWERPC_UTILS_DEPENDENCIES = zlib
> +ifeq ($(BR2_PACKAGE_POWERPC_UTILS_RTAS),y)
> +POWERPC_UTILS_DEPENDENCIES += librtas
> +endif
> POWERPC_UTILS_LICENSE = Common Public License Version 1.0
> POWERPC_UTILS_LICENSE_FILES = COPYRIGHT
>
> +ifeq ($(BR2_PACKAGE_POWERPC_UTILS_RTAS),)
> POWERPC_UTILS_CONF_OPTS = --without-librtas
> +endif
The usual convention is to put dependency handling in one place, and to have
both "with" and "without".
ifeq ($(BR2_PACKAGE_POWERPC_UTILS_RTAS),y)
POWERPC_UTILS_DEPENDENCIES += librtas
POWERPC_UTILS_CONF_OPTS = --with-librtas
else
POWERPC_UTILS_CONF_OPTS = --without-librtas
endif
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2015-05-13 3:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 4:12 [Buildroot] [PATCH v2 0/2] Improve powerpc-utils with librtas Sam Bobroff
2015-05-12 4:12 ` [Buildroot] [PATCH v2 1/2] librtas: new package Sam Bobroff
2015-05-12 4:12 ` [Buildroot] [PATCH v2 2/2] powerpc-utils: optionally use librtas Sam Bobroff
2015-05-13 3:16 ` Baruch Siach [this message]
2015-05-13 23:14 ` Sam Bobroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150513031617.GD2558@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.