From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YsNaC-0005bU-9n for mharc-grub-devel@gnu.org; Tue, 12 May 2015 23:43:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsNa9-0005bE-AL for grub-devel@gnu.org; Tue, 12 May 2015 23:43:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsNa4-0000AU-EC for grub-devel@gnu.org; Tue, 12 May 2015 23:43:41 -0400 Received: from mail-lb0-x22d.google.com ([2a00:1450:4010:c04::22d]:36535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsNa4-0000AI-6B for grub-devel@gnu.org; Tue, 12 May 2015 23:43:36 -0400 Received: by lbbqq2 with SMTP id qq2so20099116lbb.3 for ; Tue, 12 May 2015 20:43:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; bh=Y8RcjTad6kx0nEGbC9XZbPb/pAd0m96YtsY3Almib3E=; b=yWKS+pIWr3nOGlK9VOtdSEUchfx3E5NJC4jzZwrVMyclbMlu0aqxQ8zE4EggZRSyVV IZpQl1UHfdqH4TBTDRo97nPHvb4qwvV1V2xunNvTCErWEbiM928K+VIDwXooYeQIcQst tHmOOtpdqAhZz7KHqUARJrNkPb2irOF0N3MYxt+EKnjSPrELsngr/z6G5ypjEta8IQ6p M1pQ1FKtqwvNOhvSuOfj08m3yqzaMxgUa5bxXQcN1z26Y5c8oY2eZlWV6f6SAi+f83Ol fJcVuAlpLntB+3YMxxAVxNxkT/Q2zYGcU3C6VfvL+nSsrzhSwr+k+32OB3kkbQVvSjTt ONYg== X-Received: by 10.153.11.163 with SMTP id ej3mr14270837lad.105.1431488615270; Tue, 12 May 2015 20:43:35 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id sh6sm4498567lbb.31.2015.05.12.20.43.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 May 2015 20:43:34 -0700 (PDT) Date: Wed, 13 May 2015 06:43:31 +0300 From: Andrei Borzenkov To: The development of GNU GRUB Subject: Re: [PATCH v2] grub-install: Install PV Xen binaries into the upstream specified path Message-ID: <20150513064331.537baf70@opensuse.site> In-Reply-To: <551579DE.8040505@gmail.com> References: <1414099727-22463-1-git-send-email-ijc@hellion.org.uk> <551579DE.8040505@gmail.com> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22d X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2015 03:43:42 -0000 =D0=92 Fri, 27 Mar 2015 16:40:14 +0100 Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > On 23.10.2014 23:28, Ian Campbell wrote: > > Upstream have defined a specification for where guests ought to place t= heir > > xenpv grub binaries in order to facilitate chainloading from a stage 1 = grub > > loaded from dom0. > > > > http://xenbits.xen.org/docs/unstable-staging/misc/x86-xenpv-bootloader.= html > > > > The spec calls for installation into /boot/xen/pvboot-i386.elf or > > /boot/xen/pvboot-x86_64.elf. > > > > Signed-off-by: Ian Campbell > > > > --- > > v2: Respect bootdir, create /boot/xen as needed. > > --- > > util/grub-install.c | 24 ++++++++++++++++++++++-- > > 1 file changed, 22 insertions(+), 2 deletions(-) > > > > diff --git a/util/grub-install.c b/util/grub-install.c > > index 70f514c..7a7734e 100644 > > --- a/util/grub-install.c > > +++ b/util/grub-install.c > > @@ -1979,6 +1979,28 @@ main (int argc, char *argv[]) > > } > > break; > > > > + case GRUB_INSTALL_PLATFORM_I386_XEN: > > + { > > + char *path =3D grub_util_path_concat (2, bootdir, "xen"); > > + char *dst =3D grub_util_path_concat (2, path, "pvboot-i386.elf"); > > + grub_install_mkdir_p (path); > > + grub_install_copy_file (imgfile, dst, 1); > > + free (dst); > > + free (path); > > + } > > + break; > > + > > + case GRUB_INSTALL_PLATFORM_X86_64_XEN: > > + { > > + char *path =3D grub_util_path_concat (2, bootdir, "xen"); > Bootdir is not necessarily /boot. We also might want to specify xen dir=20 > to e.g. /mnt/ext2/boot/xen while still keeping GRUB itself in=20 > /boot/grub. Can you update patch to allow separate specification of=20 > bootdir and xendir? I think similar to --efi-directory it has to refer to mount point, not to final destination; --xen-directory=3D/mnt will install into /mnt/boot/xen. We do not have control over /boot/xen part. It also means that grub-install needs to strip off relative path off bootdir to build xendir on the same filesystem to get sane default. > > + char *dst =3D grub_util_path_concat (2, path, "pvboot-x86_64.elf"); > > + grub_install_mkdir_p (path); > > + grub_install_copy_file (imgfile, dst, 1); > > + free (dst); > > + free (path); > > + } > > + break; > > + > > case GRUB_INSTALL_PLATFORM_MIPSEL_LOONGSON: > > case GRUB_INSTALL_PLATFORM_MIPSEL_QEMU_MIPS: > > case GRUB_INSTALL_PLATFORM_MIPS_QEMU_MIPS: > > @@ -1987,8 +2009,6 @@ main (int argc, char *argv[]) > > case GRUB_INSTALL_PLATFORM_MIPSEL_ARC: > > case GRUB_INSTALL_PLATFORM_ARM_UBOOT: > > case GRUB_INSTALL_PLATFORM_I386_QEMU: > > - case GRUB_INSTALL_PLATFORM_I386_XEN: > > - case GRUB_INSTALL_PLATFORM_X86_64_XEN: > > grub_util_warn ("%s", > > _("WARNING: no platform-specific install was performed")); > > break; > > >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel