All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gaston Gonzalez <gascoar@gmail.com>
Cc: devel@driverdev.osuosl.org, arnd@arndb.de,
	gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org,
	joe@perches.com, navyasri.tech@gmail.com
Subject: Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning
Date: Wed, 13 May 2015 11:36:15 +0300	[thread overview]
Message-ID: <20150513083615.GS14154@mwanda> (raw)
In-Reply-To: <55527D6E.7090207@gmail.com>

What?  No, that patch can't work at all.  It will just oops directly
when you do:

> +    memcpy(&tx->p1k, &tkey->tx_ttak, p1k_len);

How come you didn't use my patch as a base to work from, you shouldn't
be passing tkip_ctx at all.

regards,
dan carpenter


  parent reply	other threads:[~2015-05-13  8:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-19 20:43 [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning Gaston Gonzalez
2015-04-20  8:24 ` Dan Carpenter
2015-04-25 22:44   ` Gaston Gonzalez
2015-04-27 10:12     ` Dan Carpenter
2015-05-07  3:09       ` Gaston Gonzalez
2015-05-08 11:03         ` Dan Carpenter
2015-05-12 22:23           ` Gaston Gonzalez
2015-05-12 23:11             ` Julian Calaby
2015-05-13  8:36             ` Dan Carpenter [this message]
2015-05-14  1:04               ` Gaston Gonzalez
2015-05-14  8:30                 ` Dan Carpenter
2015-05-14 19:35                 ` Johannes Berg
2015-05-14 19:51                   ` Dan Carpenter
2015-05-14 20:01                   ` Larry Finger
2015-05-14 22:03                   ` Gaston Gonzalez
2015-05-15  7:26                     ` Johannes Berg
2015-05-15 20:47                       ` Gaston Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150513083615.GS14154@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=arnd@arndb.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=gascoar@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=navyasri.tech@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.