From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] mxs: Possible in bug in mxs_enable_4p2_dcdc_input
Date: Wed, 13 May 2015 09:13:25 +0200 [thread overview]
Message-ID: <201505130913.25250.marex@denx.de> (raw)
In-Reply-To: <978811302.20941.1431496941951.JavaMail.open-xchange@oxbsltgw06.schlund.de>
On Wednesday, May 13, 2015 at 08:02:21 AM, Stefan Wahren wrote:
> Hi,
Hi,
> during the study of DC-DC handling in u-boot i noticed a possible bug.
>
> In case the DC-DC is already enabled the function returns without
> reenabling brown out detection. I don't think that's okay.
> A possible fix would be to do the check if DC-DC is already enabled before
> disabling brown out detection. This idea is
> attached as a draft. If it's acceptable i will send a proper patch.
What exactly would happen if you enable DCDC converter while BO detection
is already enabled ? It is possible, that enabling the DCDC would cause a
dip on the power rail and cause in turn a BO, no ? IIRC, that is the reason
why BO detection is disabled when enabling DCDC.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-05-13 7:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 6:02 [U-Boot] mxs: Possible in bug in mxs_enable_4p2_dcdc_input Stefan Wahren
2015-05-13 7:13 ` Marek Vasut [this message]
2015-05-13 8:14 ` Stefan Wahren
2015-05-13 20:03 ` Marek Vasut
2015-05-15 11:14 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201505130913.25250.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.