From: Steffen Klassert <steffen.klassert@secunet.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: <netdev@vger.kernel.org>
Subject: Re: esp4: Use high-order sequence number bits for IV generation
Date: Wed, 13 May 2015 12:18:35 +0200 [thread overview]
Message-ID: <20150513101834.GA8928@secunet.com> (raw)
In-Reply-To: <20150513072610.GA27424@gondor.apana.org.au>
On Wed, May 13, 2015 at 03:26:10PM +0800, Herbert Xu wrote:
> I noticed we were only using the low-order bits for IV generation
> when ESN is enabled. This is very bad because it means that the
> IV can repeat. We must use the full 64 bits.
Ugh. This is bad, indeed.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Patch applied to the ipsec tree, thanks!
next prev parent reply other threads:[~2015-05-13 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 7:26 esp4: Use high-order sequence number bits for IV generation Herbert Xu
2015-05-13 10:18 ` Steffen Klassert [this message]
2015-05-20 16:38 ` xfrm: Always zero high-order sequence number bits Herbert Xu
2015-05-21 10:16 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150513101834.GA8928@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.