From: Borislav Petkov <bp@alien8.de>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com,
bobby.prani@gmail.com, linux-edac@vger.kernel.org,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH tip/core/rcu 1/4] mce: Stop using array-index-based RCU primitives
Date: Wed, 13 May 2015 12:31:57 +0200 [thread overview]
Message-ID: <20150513103157.GF1517@pd.tnic> (raw)
In-Reply-To: <1431465524-32246-1-git-send-email-paulmck@linux.vnet.ibm.com>
On Tue, May 12, 2015 at 02:18:41PM -0700, Paul E. McKenney wrote:
> From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
>
> Because mce is arch-specific x86 code, there is little or no
> performance benefit of using rcu_dereference_index_check() over using
> smp_load_acquire(). It also turns out that mce is the only place that
> array-index-based RCU is used, and it would be convenient to drop
> this portion of the RCU API.
>
> This patch therefore changes rcu_dereference_index_check() uses to
> smp_load_acquire(), but keeping the lockdep diagnostics, and also
> changes rcu_access_index() uses to READ_ONCE().
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: linux-edac@vger.kernel.org
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Borislav Petkov <bp@alien8.de>
Looks good to me.
If it is easier for you carrying it in your tree:
Acked-by: Borislav Petkov <bp@suse.de>
Otherwise, let me know.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-05-13 10:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 21:18 [PATCH tip/core/rcu 0/4] Array-based RCU removals for 4.2 Paul E. McKenney
2015-05-12 21:18 ` [PATCH tip/core/rcu 1/4] mce: Stop using array-index-based RCU primitives Paul E. McKenney
2015-05-12 21:18 ` [PATCH tip/core/rcu 2/4] rcu: Eliminate " Paul E. McKenney
2015-05-13 13:08 ` Borislav Petkov
2015-05-14 20:27 ` Paul E. McKenney
2015-05-12 21:18 ` [PATCH tip/core/rcu 3/4] documentation: RCU-protected array indexes no longer supported Paul E. McKenney
2015-05-12 21:18 ` [PATCH tip/core/rcu 4/4] mce: mce_chrdev_write() can be static Paul E. McKenney
2015-05-13 10:31 ` Borislav Petkov [this message]
2015-05-13 12:51 ` [PATCH tip/core/rcu 1/4] mce: Stop using array-index-based RCU primitives Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150513103157.GF1517@pd.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhart@linux.intel.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.