From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965336AbbEMOMk (ORCPT ); Wed, 13 May 2015 10:12:40 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:35033 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964932AbbEMOMh (ORCPT ); Wed, 13 May 2015 10:12:37 -0400 Date: Wed, 13 May 2015 15:12:32 +0100 From: Al Viro To: Dan Carpenter Cc: Andy Whitcroft , Joe Perches , linux-kernel@vger.kernel.org Subject: Re: [patch v2] checkpatch: complain about GW-BASIC style label names Message-ID: <20150513141232.GC7232@ZenIV.linux.org.uk> References: <1431029858.18597.35.camel@perches.com> <20150513123712.GA2798@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150513123712.GA2798@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 13, 2015 at 03:37:12PM +0300, Dan Carpenter wrote: > GW-BASIC style label names are annoying so we can warn about that in > checkpatch. The warnings look like: > > WARNING: 'fail2' isn't informative - prefer descriptive label names > #267: FILE: ./sound/ppc/beep.c:267: > + fail2: snd_ctl_remove(chip->card, beep_ctl); > > This generates slightly under 2000 new warnings. None of them are > false positives. And all of them are complete garbage. Please, stop forcing your personal preferences upon the rest of us. Any "fixes" of that sort in fs/*.c will be passed straight to /dev/null.