From: Mike Snitzer <snitzer@redhat.com>
To: axboe@kernel.dk
Cc: dm-devel@redhat.com, hch@lst.de
Subject: linux-next dm-thinp regression due to "bio: skip atomic inc/dec of ->bi_remaining for non-chains"
Date: Wed, 13 May 2015 15:28:27 -0400 [thread overview]
Message-ID: <20150513192827.GA15831@redhat.com> (raw)
The device-mapper-test-suite (dmts) thinp tests no longer run due to
linux-block.git commit c4cf5261 ("bio: skip atomic inc/dec of
->bi_remaining for non-chains")
That commit has been the focus of some other work I have pending because
I was forced to adapt it due to bi_remaining no longer being accessible
directly. So it was surprising/interesting for this commit to take
center stage in the context of dm-thinp regression.
bios don't get submitted (simplest reproducer is the 'dd_benchmark' test
in the dmts thin-provisioning suite which just uses dd with oflag=direct
immediately after the DM thin device is created). The top-level DM
device stays at 100% utilization but no progress is made. Reverting
the commit in question resolves the problem.
But I'm able to use lvm2 to create thin devices that allow IO to
complete; so I haven't figured out what is so special about dmts (which
uses dmsetup directly instead of lvm2).
I'll see if I can figure out what might be happening... but would
welcome more eyes on this to see if anything stands out relative to the
dm-thin.c changes.
next reply other threads:[~2015-05-13 19:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 19:28 Mike Snitzer [this message]
2015-05-14 2:49 ` linux-next dm-thinp regression due to "bio: skip atomic inc/dec of ->bi_remaining for non-chains" Mike Snitzer
2015-05-14 3:29 ` Mike Snitzer
2015-05-14 7:58 ` Jan Kara
2015-05-14 15:05 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150513192827.GA15831@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.