All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com>
Cc: fstests@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] generic/326: Test the permission to set file times
Date: Thu, 14 May 2015 20:30:28 +1000	[thread overview]
Message-ID: <20150514103028.GR15721@dastard> (raw)
In-Reply-To: <CAHpGcMKfobLMLXDzX2qQhpqvGotbwHh-n3o9+NeVEtwahUMXdQ@mail.gmail.com>

On Thu, May 14, 2015 at 09:56:50AM +0200, Andreas Grünbacher wrote:
> 2015-05-14 5:19 GMT+02:00 Dave Chinner <david@fromorbit.com>:
> > Fails on XFS.
> >
> > /me looks at fs_perms and shudders at all the system() calls.
> >
> > Looks like there is no testx.file created first.
> 
> Hmm, that file was lying around from a previous run here.
> Leaky tests are fun.
> 
> > should this actually be doing "rm -f"?
> 
> That's better, indeed.

Except it still doesn't work:

generic/087 1s ... - output mismatch (see /home/dave/src/xfstests-dev/results//xfs_v4/generic/087.out.bad)
    --- tests/generic/087.out   2015-05-14 20:25:13.000000000 +1000
    +++ /home/dave/src/xfstests-dev/results//xfs_v4/generic/087.out.bad 2015-05-14 20:28:13.000000000 +1000
    @@ -1,7 +1,13 @@
     QA output created by 087
    +rm: cannot remove 'test.file': Permission denied
     t a 600 file owned by (99/99) as user/group(99/99)  PASS
    +rm: cannot remove 'test.file': Permission denied
     T a 600 file owned by (99/99) as user/group(99/99)  PASS
    +rm: cannot remove 'test.file': Permission denied
     t a 600 file owned by (99/99) as user/group(100/99)  PASS
.....

So there's something else that needs to be done here to allow the
test file to be removed....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2015-05-14 10:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 18:37 [PATCH] generic/126: Test the permission to set file times Andreas Gruenbacher
2015-05-12 23:40 ` Dave Chinner
2015-05-13  0:07   ` [PATCH] generic/326: " Andreas Gruenbacher
2015-05-14  3:19     ` Dave Chinner
2015-05-14  7:56       ` Andreas Grünbacher
2015-05-14 10:30         ` Dave Chinner [this message]
2015-05-14 13:50           ` Andreas Gruenbacher
2015-05-14 13:50             ` [PATCH] generic/087,126: Test the permission to set file times Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150514103028.GR15721@dastard \
    --to=david@fromorbit.com \
    --cc=andreas.gruenbacher@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.