From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932800AbbENKlI (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 May 2015 06:41:08 -0400
Received: from mail-wi0-f176.google.com ([209.85.212.176]:36753 "EHLO
	mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932427AbbENKlF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 May 2015 06:41:05 -0400
Date: Thu, 14 May 2015 12:40:59 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Milos Vyletel <milos@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, Paul Mackerras <paulus@samba.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
        He Kuang <hekuang@huawei.com>, Adrian Hunter <adrian.hunter@intel.com>,
        "open list:PERFORMANCE EVENT..." <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] perf/tools: put new buildid locks to use
Message-ID: <20150514104059.GA27771@gmail.com>
References: <1431588493-1474-1-git-send-email-milos@redhat.com>
 <1431588493-1474-3-git-send-email-milos@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1431588493-1474-3-git-send-email-milos@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Milos Vyletel <milos@redhat.com> wrote:

> Use new read/write locks when accesing buildid directory on places where
> we may race if multiple instances are run simultaneously.

Dunno, this will create locking interaction between multiple instances 
of perf - hanging each other, etc.

And it seems unnecessary: the buildid hierarchy is already spread out. 
What kind of races might there be?

Thanks,

	Ingo