From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Alan Stern <stern@rowland.harvard.edu>,
Andreas Fenkart <afenkart@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Huiquan Zhong <huiquan.zhong@intel.com>,
Kevin Hilman <khilman@kernel.org>, NeilBrown <neilb@suse.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Nishanth Menon <nm@ti.com>,
Peter Hurley <peter@hurleysoftware.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Ulf Hansson <ulf.hansson@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/5] PM / Wakeirq: Add automated device wake IRQ handling
Date: Thu, 14 May 2015 10:51:47 -0700 [thread overview]
Message-ID: <20150514175147.GN15563@atomide.com> (raw)
In-Reply-To: <20150514162822.GM15563@atomide.com>
* Tony Lindgren <tony@atomide.com> [150514 09:30]:
> * Felipe Balbi <balbi@ti.com> [150514 09:12]:
>
> > > int dev_pm_request_wake_irq_managed(struct device *dev, int irq);
> >
> > I don't get this. Would this request with devm_ while the former
> > wouldn't use devm_ ?
>
> Typo :) Both can be devm no problem.
...
> > > The life cycle of the request and free of the wake irq is not the
> > > same as the life cycle of the device driver. For example, serial
> > > drivers can request interrupts on startup and free them on shutdown.
> >
> > fair enough, but then we start to consider the benefits of using
> > devm_ IRQ :-)
>
> Hmm probably the extra checks do not hurt there either.
We should keep the PM related functions called dev_pm_*, using
devm_pm_* just gets hard to pronounce.. So yeah I too am thinking
just not using devm here at all as the consumer drivers are not
allocating anything.
Regards,
Tony
next prev parent reply other threads:[~2015-05-14 17:51 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 23:36 [PATCHv3 0/5] Linux generic wakeirq handling Tony Lindgren
2015-05-13 23:36 ` [PATCH 1/5] PM / Runtime: Update last_busy in rpm_resume Tony Lindgren
2015-05-20 7:36 ` Ulf Hansson
2015-05-13 23:36 ` [PATCH 2/5] PM / Wakeirq: Add automated device wake IRQ handling Tony Lindgren
2015-05-14 2:06 ` Felipe Balbi
2015-05-14 2:06 ` Felipe Balbi
2015-05-14 15:51 ` Alan Stern
2015-05-14 15:51 ` Alan Stern
2015-05-14 15:54 ` Felipe Balbi
2015-05-14 15:54 ` Felipe Balbi
2015-05-14 15:59 ` Tony Lindgren
2015-05-14 16:09 ` Felipe Balbi
2015-05-14 16:09 ` Felipe Balbi
2015-05-14 16:28 ` Tony Lindgren
2015-05-14 17:51 ` Tony Lindgren [this message]
2015-05-14 21:15 ` Tony Lindgren
2015-05-14 21:25 ` Felipe Balbi
2015-05-14 21:25 ` Felipe Balbi
2015-05-14 22:00 ` Rafael J. Wysocki
2015-05-14 21:59 ` Tony Lindgren
2015-05-15 22:25 ` Tony Lindgren
2015-05-16 1:56 ` Felipe Balbi
2015-05-16 1:56 ` Felipe Balbi
2015-05-18 22:05 ` Tony Lindgren
2015-05-18 23:44 ` Tony Lindgren
2015-05-19 14:04 ` Rafael J. Wysocki
2015-05-19 14:26 ` Rafael J. Wysocki
2015-05-19 15:09 ` Tony Lindgren
2015-05-19 18:18 ` Tony Lindgren
2015-05-19 23:01 ` Rafael J. Wysocki
2015-05-19 22:41 ` Thomas Gleixner
2015-05-19 23:31 ` Rafael J. Wysocki
2015-05-19 23:27 ` Tony Lindgren
2015-05-20 0:25 ` Rafael J. Wysocki
2015-05-20 2:10 ` Tony Lindgren
2015-05-21 0:54 ` Rafael J. Wysocki
2015-05-21 0:35 ` Tony Lindgren
2015-05-21 1:40 ` Felipe Balbi
2015-05-21 1:40 ` Felipe Balbi
2015-05-19 15:15 ` Tony Lindgren
2015-05-13 23:36 ` [PATCH 3/5] serial: omap: Switch wake-up interrupt to generic wakeirq Tony Lindgren
2015-05-28 14:56 ` Tony Lindgren
2015-05-31 7:16 ` Greg Kroah-Hartman
2015-06-01 22:05 ` Tony Lindgren
2015-05-13 23:36 ` [PATCH 4/5] serial: 8250_omap: Move " Tony Lindgren
2015-05-13 23:36 ` [PATCH 5/5] mmc: omap_hsmmc: Change wake-up interrupt to use " Tony Lindgren
2015-05-25 8:38 ` Ulf Hansson
2015-05-27 22:42 ` Rafael J. Wysocki
2015-05-27 22:45 ` Tony Lindgren
2015-05-28 14:36 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514175147.GN15563@atomide.com \
--to=tony@atomide.com \
--cc=afenkart@gmail.com \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=huiquan.zhong@intel.com \
--cc=khilman@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=neilb@suse.de \
--cc=nm@ti.com \
--cc=peter@hurleysoftware.com \
--cc=rafael.j.wysocki@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.