[PATCH 1/1] tools selftests: Fix 'clean' target with make 3.81

[PATCH 1/1] tools selftests: Fix 'clean' target with make 3.81

[Arnaldo Carvalho de Melo]

Make 3.81 doesn't have the 'undefine' command, use 'override  var ='
instead.

Tested-by: Shuah Khan <shuahkh@osg.samsung.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Link: http://lkml.kernel.org/r/20150514151225.GH23588@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 95abddcd7839..f76830643086 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -27,7 +27,7 @@ TARGETS_HOTPLUG += memory-hotplug
 # Makefile to avoid test build failures when test
 # Makefile doesn't have explicit build rules.
 ifeq (1,$(MAKELEVEL))
-undefine LDFLAGS
+override LDFLAGS =
 override MAKEFLAGS =
 endif
 
-- 
2.1.0

Re: [PATCH 1/1] tools selftests: Fix 'clean' target with make 3.81

[Shuah Khan]

On 05/14/2015 01:55 PM, Arnaldo Carvalho de Melo wrote:
> Make 3.81 doesn't have the 'undefine' command, use 'override  var ='
> instead.
> 
> Tested-by: Shuah Khan <shuahkh@osg.samsung.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Link: http://lkml.kernel.org/r/20150514151225.GH23588@kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/testing/selftests/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 95abddcd7839..f76830643086 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -27,7 +27,7 @@ TARGETS_HOTPLUG += memory-hotplug
>  # Makefile to avoid test build failures when test
>  # Makefile doesn't have explicit build rules.
>  ifeq (1,$(MAKELEVEL))
> -undefine LDFLAGS
> +override LDFLAGS =
>  override MAKEFLAGS =
>  endif
>  
> 

I will get this into 4.2 unless you think there is real
need for this to go into 4.1 right away.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

Re: [PATCH 1/1] tools selftests: Fix 'clean' target with make 3.81

[Arnaldo Carvalho de Melo]

Em Thu, May 14, 2015 at 04:16:51PM -0600, Shuah Khan escreveu:
> On 05/14/2015 01:55 PM, Arnaldo Carvalho de Melo wrote:
> > +++ b/tools/testing/selftests/Makefile
> > @@ -27,7 +27,7 @@ TARGETS_HOTPLUG += memory-hotplug
> >  ifeq (1,$(MAKELEVEL))
> > -undefine LDFLAGS
> > +override LDFLAGS =
> >  override MAKEFLAGS =
 
> I will get this into 4.2 unless you think there is real
> need for this to go into 4.1 right away.

Send it when its most convenient to you, this is trivial, odd corner
case stuff.

- Arnaldo