From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Yt9IT-0003zt-Lo for mharc-grub-devel@gnu.org; Fri, 15 May 2015 02:40:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yt9IQ-0003zm-Je for grub-devel@gnu.org; Fri, 15 May 2015 02:40:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yt9IL-0002zn-NK for grub-devel@gnu.org; Fri, 15 May 2015 02:40:34 -0400 Received: from mail-la0-x229.google.com ([2a00:1450:4010:c03::229]:35183) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yt9IL-0002zZ-Fm for grub-devel@gnu.org; Fri, 15 May 2015 02:40:29 -0400 Received: by labbd9 with SMTP id bd9so104880684lab.2 for ; Thu, 14 May 2015 23:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=pxA5kFJc0xv/S2AmgXWVntVwFmYmw5MonwuV0kPLx0s=; b=Rg3nJcq06pO2R9lFvaMiiv87Z3jT+Ss0lbv2sS92EInFaewF3myNUn4bDDVwWmNFQP EimKb/E24fNtFDxxdWv8DUbSuF8YXFQc8vdgSAmuteQMOhpDxi8Ih/X7YhItdsJTKEAd A/U6GF1nszgWLaYFe0phwhv+f9GtQfYR4u8mgTTpbdn1N0tmFapP7f+Tzi0zj/zHqcCz Kbuq3kVSwYE2XOiKdwpsykBmGizbQ7w+bI3v6qhDwwvhwn6ASv0uTPRmmQaTbSq5S73H DiUR68nOUJvj6QauYoXVqzsPKuFCnA3AxCNnEEpoKbJK/Z1FPmxIhmABdWDldPKyagX6 UiVw== X-Received: by 10.112.131.104 with SMTP id ol8mr6185832lbb.58.1431672028501; Thu, 14 May 2015 23:40:28 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id 4sm213417lai.36.2015.05.14.23.40.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2015 23:40:27 -0700 (PDT) Date: Fri, 15 May 2015 09:40:26 +0300 From: Andrei Borzenkov To: Michael Chang Subject: Re: [PATCH v1] Support DHCPv6 and UEFI IPv6 PXE Message-ID: <20150515094026.22c4e669@opensuse.site> In-Reply-To: <1431420590-7245-1-git-send-email-mchang@suse.com> References: <1431420590-7245-1-git-send-email-mchang@suse.com> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::229 Cc: grub-devel@gnu.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2015 06:40:36 -0000 =D0=92 Tue, 12 May 2015 16:49:47 +0800 Michael Chang =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > This patch set tries to make support of configuring IPv6 network interface > through the DHCPv6 protocol. A new command, net_bootp6, is therefore intr= oduced > to serve the purpose. You can think it as DHCPv6/IPv6 version of the exis= ting > net_bootp command. >=20 Note that spec actually suggests (requires?) that DHCPv6 transaction is triggered by receiving Router Advertisement with M/O bits set. > In addition to that, the UEFI IPv6 PXE support can be easily done by shar= ing > the same routine with net_bootp6 to parse DHCPv6 Reply packet cached in t= he > firmware. >=20 Looking in EFI spec I do not see it explaining what content this dhcp_ack packet has for IPv6. I mean, DHCPv6 has neither Discover not Acknowledge, and full DHCPv6 transaction requires *two* packets - one for getting address and one for getting other options (DNS/boot server). Let's see how it works in real world :) > changes in v1: > - Added upper boundary check in find_dhcpv6_option > - Fix memory leak and freeing NULL pointer > - Improved error message logging to not get lost > - Use grub_cpu_to_be16_compile_time for endianess conversion when appropr= iate > - Removed grub_dhcpv6_dns_servers structure and use 16 bytes blocks > - Avoud magic numbers and use more descriptive sizeof when populating net= buff > - Move include/grub/efi/api.h to UEFI IPv6 PXE support patch > - Document the net_bootp6 command >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel