From: Brandon Smith <freedom@reardencode.com>
To: Abelardo Ricart III <aricart@memnix.com>
Cc: Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, mpatocka@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: Regression: Disk corruption with dm-crypt and kernels >= 4.0
Date: Fri, 15 May 2015 08:04:42 -0700 [thread overview]
Message-ID: <20150515150442.GB35834@hank.reardencode.com> (raw)
In-Reply-To: <1430523735.5352.1.camel@memnix.com>
On 2015-05-01 (Fri) at 19:42:15 -0400, Abelardo Ricart III wrote:
> > > The patchset in question was tested quite heavily so this is a
> > > surprising report. I'm noticing you are opting in to dm-crypt discard
> > > support. Have you tested without discards enabled?
> >
> > I've disabled discards universally and rebuilt a vanilla kernel. After running
> > my heavy read-write-sync scripts, everything seems to be working fine now. I
> > suppose this could be something that used to fail silently before, but now
> > produces bad behavior? I seem to remember having something in my message log
> > about "discards not supported on this device" when running with it enabled
> > before.
>
> Forgive me, but I spoke too soon. The corruption and libata errors are still
> there, as was evidenced when I went to reboot and got treated to an eye full of
> "read-only filesystem" and ata errors.
>
> So no, disabling discards unfortunately did nothing to help.
I've been experiencing the same problem. Vanilla 4.0 series kernels,
dm-crypt, with/or without discards, on a ThinkPad X1 Carbon with a
LiteOn LGT-256M6G SSD.
After some of googling around, I found some chatter relating to changes
in NCQ on SSDs in 4.0. Been running w/o NCQ for a full kernel build so
far without issue. Perhaps there's been some change in the interaction
between dm-crypt and NCQ?
Abelardo, can you try w/o NCQ and see if that helps your situation?
Best,
--Brandon
next prev parent reply other threads:[~2015-05-15 15:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 4:37 Regression: Disk corruption with dm-crypt and kernels >= 4.0 Abelardo Ricart III
2015-05-01 21:17 ` Mike Snitzer
2015-05-01 22:24 ` Abelardo Ricart III
2015-05-01 23:42 ` Abelardo Ricart III
2015-05-15 15:04 ` Brandon Smith [this message]
2015-05-18 14:36 ` Abelardo Ricart III
2015-06-02 17:51 ` Mikulas Patocka
2015-06-03 2:21 ` Abelardo Ricart III
2015-06-03 2:21 ` Abelardo Ricart III
2015-09-11 16:11 ` Mike Snitzer
2015-05-01 21:47 ` [dm-devel] " Alasdair G Kergon
2015-05-02 0:19 ` Abelardo Ricart III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150515150442.GB35834@hank.reardencode.com \
--to=freedom@reardencode.com \
--cc=aricart@memnix.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.