From: Mike Snitzer <snitzer@redhat.com>
To: Lidong Zhong <lzhong@suse.com>
Cc: lwang@suse.com, heinzm@redhat.com, dm-devel@redhat.com
Subject: Re: dm-raid1: keep writing after leg failure
Date: Fri, 15 May 2015 12:11:08 -0400 [thread overview]
Message-ID: <20150515161108.GA28234@redhat.com> (raw)
In-Reply-To: <1431497050-10098-1-git-send-email-lzhong@suse.com>
On Wed, May 13 2015 at 2:04am -0400,
Lidong Zhong <lzhong@suse.com> wrote:
> Currently if there is a leg failure, the bio will be put into the hold
> list until userspace replace/remove the leg. Here we are trying to make
> dm-raid1 ignore the failure and keep the following bios going on.
> This is because there maybe a temporary path failure in clvmd
> which leads to cluster raid1 remove/replace the fake device failure. And
> it takes a long time to do the full sync if we readd the device back.
>
> This patch merges the former five small patches to implement this
> feature. The userspace should pass "keep_log" into kernel to make this feature to
> take effect when creating dm-raid1, same as "handle_errors".
>
> Signed-off-by: Lidong Zhong <lzhong@suse.com>
> Tested-by: Liuhua Wang <lwang@suse.com>
I've staged a revised patch for 4.2 here:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=164a064dd85801986f3190e6edd119b6fc9a05c5
The big things I clarified/cleaned are:
1) keep_log depends on handle_errors feature
2) feature reporting via 'dmsetup table' needed to be decoupled
otherwise any future feature would've forced this same cleanup.
3) Cleaned up header and in-code comments.
4) bumped the target version
Please let me know if you see nay issues with this version.
Thanks,
Mike
next prev parent reply other threads:[~2015-05-15 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 6:04 [PATCH] dm-raid1: keep writing after leg failure Lidong Zhong
2015-05-13 15:56 ` Heinz Mauelshagen
2015-05-15 16:11 ` Mike Snitzer [this message]
2015-05-18 3:49 ` Lidong Zhong
-- strict thread matches above, loose matches on Subject: below --
2015-05-18 5:31 Lidong Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150515161108.GA28234@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=heinzm@redhat.com \
--cc=lwang@suse.com \
--cc=lzhong@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.