From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [RFC][PATCHSET v3] non-recursive pathname resolution & RCU symlinks Date: Sat, 16 May 2015 09:39:13 +1000 Message-ID: <20150515233913.GI4316@dastard> References: <20150505052205.GS889@ZenIV.linux.org.uk> <20150511180650.GA4147@ZenIV.linux.org.uk> <20150513222533.GA24192@ZenIV.linux.org.uk> <20150514033040.GF7232@ZenIV.linux.org.uk> <20150514112304.GT15721@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , Al Viro , Linux Kernel Mailing List , linux-fsdevel , Christoph Hellwig , Neil Brown To: Andreas Dilger Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, May 15, 2015 at 03:15:48PM -0600, Andreas Dilger wrote: > On May 14, 2015, at 5:23 AM, Dave Chinner wrote: > > > > On Wed, May 13, 2015 at 08:52:59PM -0700, Linus Torvalds wrote: > >> On Wed, May 13, 2015 at 8:30 PM, Al Viro wrote: > >>> > >>> Maybe... I'd like to see the profiles, TBH - especially getxattr() and > >>> access() frequency on various loads. Sure, make(1) and cc(1) really care > >>> about stat() very much, but I wouldn't be surprised if something like > >>> httpd or samba would be hitting getxattr() a lot... > >> > >> So I haven't seen samba profiles in ages, but iirc we have more > >> serious problems than trying to speed up basic filename lookup. > >> > >> At least long long ago, inode semaphore contention was a big deal, > >> largely due to readdir(). > > > > It still is - it's the prime reason people still need to create > > hashed directory structures so that they can get concurrency in > > directory operations. IMO, concurrency in directory operations is a > > more important problem to solve than worrying about readdir speed; > > in large filesystems readdir and lookup are IO bound operations and > > so everything serialises on the IO as it's done with the i_mutex > > held.... > > We've had a patch[*] to add ext4 parallel directory operations in Lustre for > a few years, that adds separate locks for each internal tree and leaf block > instead of using i_mutex, so it scales as the size of the directory grows. > This definitely improved many-threaded directory create/lookup/unlink > performance (rename still uses a single lock). Yup, we can do the same to XFS to implement concurrent modifications. Cheers, Dave. -- Dave Chinner david@fromorbit.com