From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
sboyd@codeaurora.org, prarit@redhat.com, skannan@codeaurora.org,
Srivatsa Bhat <srivatsa@mit.edu>
Subject: Re: [PATCH V3 07/14] cpufreq: Don't allow updating inactive-policies from sysfs
Date: Sat, 16 May 2015 07:31:46 +0530 [thread overview]
Message-ID: <20150516020146.GD4600@linux> (raw)
In-Reply-To: <2674706.qWzjVNUKcn@vostro.rjw.lan>
On 16-05-15, 03:10, Rafael J. Wysocki wrote:
> The dash after "inactive" in the subject is not necessary IMO.
Okay
> On Friday, May 08, 2015 11:53:50 AM Viresh Kumar wrote:
> > + /*
> > + * Policy might not be active currently, and so we shouldn't try
> > + * updating any values here. policy->cpus is cleared for inactive policy
> > + * and so cpufreq_cpu_get_raw() should fail.
>
> These comments don't really clarify things. It'd be better to say something
> like "Updating inactive policies is invalid, so avoid doing that."
Okay..
> > + */
> > + if (unlikely(policy_is_inactive(policy))) {
> > + ret = -EPERM;
>
> This doesn't seem to be the appropriate error code to return here.
>
> -EBUSY or -EAGAIN would be better IMO.
Okay
--
viresh
next prev parent reply other threads:[~2015-05-16 2:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 6:23 [PATCH V3 00/14] cpufreq: Don't loose cpufreq history on CPU hotplug Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 01/14] cpufreq: Create for_each_{in}active_policy() Viresh Kumar
2015-05-08 21:46 ` Rafael J. Wysocki
2015-05-09 2:27 ` Viresh Kumar
2015-05-12 6:04 ` Viresh Kumar
2015-05-12 6:50 ` [PATCH V4 " Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 02/14] cpufreq: Don't clear cpufreq_cpu_data and policy list for inactive policies Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 03/14] cpufreq: Get rid of cpufreq_cpu_data_fallback Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 04/14] cpufreq: Don't traverse all active policies to find policy for a cpu Viresh Kumar
2015-05-12 6:52 ` [PATCH V4 " Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 05/14] cpufreq: Manage governor usage history with 'policy->last_governor' Viresh Kumar
2015-05-12 6:52 ` [PATCH V4 " Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 06/14] cpufreq: Mark policy->governor = NULL for inactive policies Viresh Kumar
2015-05-12 6:52 ` [PATCH V4 " Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 07/14] cpufreq: Don't allow updating inactive-policies from sysfs Viresh Kumar
2015-05-16 1:10 ` Rafael J. Wysocki
2015-05-16 2:01 ` Viresh Kumar [this message]
2015-05-08 6:23 ` [PATCH V3 08/14] cpufreq: Track cpu managing sysfs kobjects separately Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 09/14] cpufreq: Stop migrating sysfs files on hotplug Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 10/14] cpufreq: Remove cpufreq_update_policy() Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 11/14] cpufreq: Initialize policy->kobj while allocating policy Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 12/14] cpufreq: Call cpufreq_policy_put_kobj() from cpufreq_policy_free() Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 13/14] cpufreq: Restart governor as soon as possible Viresh Kumar
2015-05-08 6:23 ` [PATCH V3 14/14] cpufreq: Add support for physical hoplug of CPUs Viresh Kumar
2015-05-16 1:18 ` Rafael J. Wysocki
2015-05-16 2:13 ` Viresh Kumar
2015-05-18 0:30 ` Rafael J. Wysocki
2015-05-18 2:11 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150516020146.GD4600@linux \
--to=viresh.kumar@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=skannan@codeaurora.org \
--cc=srivatsa@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.