From: Ingo Molnar <mingo@kernel.org>
To: Len Brown <lenb@kernel.org>
Cc: "Jan H. Schönherr" <jschoenh@amazon.de>,
"Thomas Gleixner" <tglx@linutronix.de>, "X86 ML" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Anthony Liguori" <aliguori@amazon.com>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>, "Tim Deegan" <tim@xen.org>,
"Gang Wei" <gang.wei@intel.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [PATCH] x86: skip delays during SMP initialization similar to Xen
Date: Sun, 17 May 2015 07:02:21 +0200 [thread overview]
Message-ID: <20150517050220.GA15791@gmail.com> (raw)
In-Reply-To: <CAJvTdKm2PLZm8ZxV2+TBn9aSrdmeZuuNB5VBeixU+JemGSnpgA@mail.gmail.com>
* Len Brown <lenb@kernel.org> wrote:
> On Thu, May 14, 2015 at 2:44 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> >
> >> BTW. this time can be reduced by 7% (113 ms) by deleting
> >> announce_cpu():
> >>
> >> [ 1.445815] x86: Booted up 4 nodes, 120 CPUs
> >
> > so that kind of info looks pretty useful, especially when there's
> > hangs/failures.
>
> I think the messages we print on failure are useful.
> I think the success case should be a 1-line summary.
But we usually don't know a failure until it happens, and then people
often don't know which quirky debug option to turn on before sending a
capture of the failure.
It also pretty compressed and looks kind of cool, especially with
larger CPU counts. Would love to see a 6K CPUs system boot up ;-)
> > I'm wondering what takes 113 msecs to print 120 CPUs - that's
> > about 1 msec per a few chars of printk produced, seems excessive.
> > Do you have any idea what's going on there? Does your system print
> > to a serial console perhaps?
>
> Yes, serial console -- that server is actually much
> closer to you than it is to me, it is in Finland:-)
LOL ;-)
> I should benchmark it, because 115200 should be faster...
So 115200 baud == 14400 bytes/sec == 14.4 bytes/msec == 0.07 msecs/byte
So with 120 CPUs we print about 5-6 chars per CPU, which is 6*120==720
bytes, which should take about 50 msecs.
So serial explains about half of the observed overhead.
Thanks,
Ingo
next prev parent reply other threads:[~2015-05-17 5:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 9:42 [PATCH] x86: skip delays during SMP initialization similar to Xen Jan H. Schönherr
2015-05-06 8:27 ` Ingo Molnar
2015-05-07 1:27 ` Len Brown
2015-05-07 10:23 ` Ingo Molnar
2015-05-12 8:03 ` Len Brown
2015-05-12 9:43 ` Ingo Molnar
2015-05-12 9:47 ` Ingo Molnar
2015-05-12 10:12 ` Borislav Petkov
2015-05-14 6:36 ` Len Brown
2015-05-14 6:44 ` Ingo Molnar
2015-05-16 8:46 ` Len Brown
2015-05-17 5:02 ` Ingo Molnar [this message]
2015-05-28 5:31 ` Len Brown
2015-05-29 2:16 ` Len Brown
2015-05-14 7:18 ` Len Brown
2015-05-14 14:25 ` "Jan H. Schönherr"
2015-05-14 17:57 ` Ingo Molnar
2015-05-16 9:07 ` Len Brown
2015-05-17 5:26 ` Ingo Molnar
2015-05-06 10:13 ` [tip:x86/apic] x86/smpboot: Skip " tip-bot for Jan H. Schönherr
2015-05-13 7:15 ` [tip:x86/apic] Revert f5d6a52f5111 ("x86/smpboot: Skip delays during SMP initialization similar to Xen") tip-bot for Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150517050220.GA15791@gmail.com \
--to=mingo@kernel.org \
--cc=aliguori@amazon.com \
--cc=gang.wei@intel.com \
--cc=hpa@zytor.com \
--cc=jschoenh@amazon.de \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tim@xen.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.