All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Dump some DPLL fields in pipe config debug
Date: Mon, 18 May 2015 09:57:08 +0200	[thread overview]
Message-ID: <20150518075708.GE15256@phenom.ffwll.local> (raw)
In-Reply-To: <20150513164140.GD10669@strange.amr.corp.intel.com>

On Wed, May 13, 2015 at 05:41:40PM +0100, Damien Lespiau wrote:
> On Wed, May 13, 2015 at 04:51:07PM +0100, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > 
> > Tried to get the platform split right, please shout if I failed.
> > 
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> So, previously, we used to dump the whole list of states, even when the
> platform didn't care about all of them. I do like a platform-aware dump
> of the state better and this looks right to me (surely we can break the
> strings at a ','!).
> 
> You probably also want to add pipe_config->ddi_pll_sel on DDI platforms
> as it encodes the actual PLL selection (at least) and maybe look at the
> other DPLL-related states in there (I can give a r-b tag without those
> :p)
> 
> A small typo below.

Not convinced, for the same reason that we don't have platform checks
(except where absolutely necessary) in the pipe_config_compare code: No
one will notice bug here until it's too late. Otoh the pipe dump code
always seems to be lacking.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-05-18  7:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13 15:51 [PATCH 1/2] drm/i915: Dump some DPLL fields in pipe config debug Tvrtko Ursulin
2015-05-13 15:51 ` [PATCH 2/2] drm/i915: Output scaler related pipe config debug in a single line Tvrtko Ursulin
2015-05-13 16:26   ` Damien Lespiau
2015-05-15 13:48   ` shuang.he
2015-05-18  5:27   ` Konduru, Chandra
2015-05-18  7:58     ` Daniel Vetter
2015-05-13 16:41 ` [PATCH 1/2] drm/i915: Dump some DPLL fields in pipe config debug Damien Lespiau
2015-05-18  7:57   ` Daniel Vetter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-05-14 12:38 Tvrtko Ursulin
2015-05-14 12:58 ` Damien Lespiau
2015-05-18  8:06   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150518075708.GE15256@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=damien.lespiau@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.