From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v9 4/4] crypto: Add Allwinner Security System crypto accelerator Date: Mon, 18 May 2015 09:24:49 +0200 Message-ID: <20150518092449.2364d21e@bbrezillon> References: <1431608341-10936-1-git-send-email-clabbe.montjoie@gmail.com> <1431608341-10936-5-git-send-email-clabbe.montjoie@gmail.com> <20150517104508.468b032f@bbrezillon> <20150517103440.GA7800@gondor.apana.org.au> <20150517124811.797fab32@bbrezillon> <20150518004121.GA11910@gondor.apana.org.au> Reply-To: boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: LABBE Corentin , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org, joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To: Herbert Xu Return-path: In-Reply-To: <20150518004121.GA11910-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , List-Id: linux-crypto.vger.kernel.org Hi Herbert, On Mon, 18 May 2015 08:41:21 +0800 Herbert Xu wrote: > On Sun, May 17, 2015 at 12:48:11PM +0200, Boris Brezillon wrote: > > > > Yep, but then they shouldn't be declared with CRYPTO_ALG_ASYNC and as an not ^ > > ablkcipher algorithm (*Asynchronous* Block Cipher), right ? > > Right. They can still use ablkcipher but should clear the ASYNC > bit. Okay, just to be sure, what does "Asynchronous" mean in ablkcipher or ahash ? Is it related to the fact that crypto operations can be done in multiple steps (e.g.: one set_key + several encrypt chunk operations), or is this something else ? Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@free-electrons.com (Boris Brezillon) Date: Mon, 18 May 2015 09:24:49 +0200 Subject: [PATCH v9 4/4] crypto: Add Allwinner Security System crypto accelerator In-Reply-To: <20150518004121.GA11910@gondor.apana.org.au> References: <1431608341-10936-1-git-send-email-clabbe.montjoie@gmail.com> <1431608341-10936-5-git-send-email-clabbe.montjoie@gmail.com> <20150517104508.468b032f@bbrezillon> <20150517103440.GA7800@gondor.apana.org.au> <20150517124811.797fab32@bbrezillon> <20150518004121.GA11910@gondor.apana.org.au> Message-ID: <20150518092449.2364d21e@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Herbert, On Mon, 18 May 2015 08:41:21 +0800 Herbert Xu wrote: > On Sun, May 17, 2015 at 12:48:11PM +0200, Boris Brezillon wrote: > > > > Yep, but then they shouldn't be declared with CRYPTO_ALG_ASYNC and as an not ^ > > ablkcipher algorithm (*Asynchronous* Block Cipher), right ? > > Right. They can still use ablkcipher but should clear the ASYNC > bit. Okay, just to be sure, what does "Asynchronous" mean in ablkcipher or ahash ? Is it related to the fact that crypto operations can be done in multiple steps (e.g.: one set_key + several encrypt chunk operations), or is this something else ? Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751910AbbERHZD (ORCPT ); Mon, 18 May 2015 03:25:03 -0400 Received: from down.free-electrons.com ([37.187.137.238]:43719 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751920AbbERHYz (ORCPT ); Mon, 18 May 2015 03:24:55 -0400 Date: Mon, 18 May 2015 09:24:49 +0200 From: Boris Brezillon To: Herbert Xu Cc: LABBE Corentin , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, maxime.ripard@free-electrons.com, linux@arm.linux.org.uk, davem@davemloft.net, akpm@linux-foundation.org, gregkh@linuxfoundation.org, mchehab@osg.samsung.com, joe@perches.com, tj@kernel.org, arnd@arndb.de, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v9 4/4] crypto: Add Allwinner Security System crypto accelerator Message-ID: <20150518092449.2364d21e@bbrezillon> In-Reply-To: <20150518004121.GA11910@gondor.apana.org.au> References: <1431608341-10936-1-git-send-email-clabbe.montjoie@gmail.com> <1431608341-10936-5-git-send-email-clabbe.montjoie@gmail.com> <20150517104508.468b032f@bbrezillon> <20150517103440.GA7800@gondor.apana.org.au> <20150517124811.797fab32@bbrezillon> <20150518004121.GA11910@gondor.apana.org.au> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Herbert, On Mon, 18 May 2015 08:41:21 +0800 Herbert Xu wrote: > On Sun, May 17, 2015 at 12:48:11PM +0200, Boris Brezillon wrote: > > > > Yep, but then they shouldn't be declared with CRYPTO_ALG_ASYNC and as an not ^ > > ablkcipher algorithm (*Asynchronous* Block Cipher), right ? > > Right. They can still use ablkcipher but should clear the ASYNC > bit. Okay, just to be sure, what does "Asynchronous" mean in ablkcipher or ahash ? Is it related to the fact that crypto operations can be done in multiple steps (e.g.: one set_key + several encrypt chunk operations), or is this something else ? Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com