From: Cyril Hrubis <chrubis@suse.cz>
To: Cui Bixuan <cuibixuan@huawei.com>
Cc: ltp-list@lists.sourceforge.net, zhuyanpeng@huawei.com,
zhanyongming@huawei.com
Subject: Re: [LTP] [PATCH] open/open12: Check the kernel version for 'MS_STRICTATIME'
Date: Mon, 18 May 2015 13:52:04 +0200 [thread overview]
Message-ID: <20150518115203.GE4104@rei> (raw)
In-Reply-To: <5555A746.4080006@huawei.com>
Hi!
> > This is not right place to do it. The flag is used only when we need to
> > mount the loop device so the check should be done only if we are about
> > to acquire the device. And we should set the skip_noatime flag there as
> > well.
> >
> Your opinion is to add the check after `if (tst_path_has_mnt_flags(cleanup, NULL, mount_flags))`
> and then set the skip_noatime flag to 1 ?
Yes, because there is no need to skip the test if we are not even going
to mount the loop device.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2015-05-18 11:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 6:34 [LTP] [PATCH] performing test on loop device if noatime or relatime specified Han Pingtian
2015-05-04 11:53 ` Cyril Hrubis
2015-05-06 13:55 ` Han Pingtian
2015-05-07 12:48 ` Cyril Hrubis
2015-05-08 1:41 ` Han Pingtian
2015-05-12 12:50 ` Cui Bixuan
2015-05-12 13:48 ` Cyril Hrubis
[not found] ` <55530639.2070806@huawei.com>
2015-05-13 8:14 ` Cyril Hrubis
[not found] ` <55559C6A.9090001@huawei.com>
2015-05-18 11:56 ` [LTP] [PATCH] open/open12: compile error Cyril Hrubis
[not found] ` <55530742.3030707@huawei.com>
2015-05-13 9:03 ` [LTP] [PATCH] open/open12: Check the kernel version for 'MS_STRICTATIME' Cyril Hrubis
[not found] ` <5555A746.4080006@huawei.com>
2015-05-18 11:52 ` Cyril Hrubis [this message]
[not found] ` <5559DDD9.4090807@huawei.com>
2015-05-27 14:20 ` [LTP] [PATCH 2/2 v2] " Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518115203.GE4104@rei \
--to=chrubis@suse.cz \
--cc=cuibixuan@huawei.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=zhanyongming@huawei.com \
--cc=zhuyanpeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.