From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jagan Teki <jteki@openedev.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2] staging: rtl8712: Use ether_addr_copy() instead of memcpy()
Date: Mon, 18 May 2015 17:38:44 +0300 [thread overview]
Message-ID: <20150518143844.GK14154@mwanda> (raw)
In-Reply-To: <1431958626-4345-1-git-send-email-jteki@openedev.com>
On Mon, May 18, 2015 at 07:47:06PM +0530, Jagan Teki wrote:
> struct eeprom_priv {
> u8 bautoload_fail_flag; /* 0 1 */
> u8 bempty; /* 1 1 */
> u8 sys_config; /* 2 1 */
> u8 mac_addr[6]; /* 3 6 */
> ......
> };
This means it's not aligned as we want.
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-18 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 14:17 [PATCH v2] staging: rtl8712: Use ether_addr_copy() instead of memcpy() Jagan Teki
2015-05-18 14:38 ` Dan Carpenter [this message]
2015-05-18 16:04 ` Jagan Teki
2015-05-18 16:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518143844.GK14154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jteki@openedev.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.