From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver Date: Mon, 18 May 2015 08:27:37 -0700 Message-ID: <20150518152737.GA14403@roeck-us.net> References: <6a51f163b99edfad9165ad29609abb072dbaa2b7.1431621833.git.stwiss.opensource@diasemi.com> <55555639.8090505@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7014B22B63A@SW-EX-MBX02.diasemi.com> <5555ED4F.5070003@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7014B22B6E2@SW-EX-MBX02.diasemi.com> <20150515202005.GA23133@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7014B22B8C8@SW-EX-MBX02.diasemi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7014B22B8C8-68WUHU125fLzLL1Oxlh9IgLouzNaz+3S@public.gmane.org> Sender: linux-watchdog-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Opensource [Steve Twiss]" Cc: LINUXKERNEL , LINUXWATCHDOG , Wim Van Sebroeck , Alessandro Zummo , DEVICETREE , David Dajun Chen , Dmitry Torokhov , Ian Campbell , Kumar Gala , LINUXINPUT , Lee Jones , Liam Girdwood , Mark Brown , Mark Rutland , Pawel Moll , RTCLINUX , Rob Herring , Samuel Ortiz , Support Opensource List-Id: linux-input@vger.kernel.org On Mon, May 18, 2015 at 02:15:01PM +0000, Opensource [Steve Twiss] wrote: > On 15 May 2015 21:20 Guenter Roeck, > > > > > > + > > > > > +/* E_WDG_WARN interrupt handler */ > > > > > +static irqreturn_t da9062_wdt_wdg_warn_irq_handler(int irq, void*data) > > > > > +{ > > > > > + struct da9062_watchdog *wdt = data; > > > > > + > > > > > + dev_notice(wdt->hw->dev, "Watchdog timeout warning trigger.\n"); > > > > > + return IRQ_HANDLED; > > > > > +} > > > > > + > > > > > > On 15 May 2015 13:58 Guenter Roeck wrote: > > > > > > [...] > > > > > > > >>> + > > > > >>> + irq = platform_get_irq_byname(pdev, "WDG_WARN"); > > > > >>> + if (irq < 0) { > > > > >>> + dev_err(wdt->hw->dev, "Failed to get IRQ.\n"); > > > > >>> + ret = irq; Hi Steve, Since the interrupt is optional, the driver should also not fail to load if no interrupt is assigned to it in the first place. On a separate note, there was a comment stating that the da9062 watchdog is identical to the da9063 watchdog. If so, why can't you just use the da9063 watchdog driver ? Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bh-25.webhostbox.net (bh-25.webhostbox.net. [208.91.199.152]) by gmr-mx.google.com with ESMTPS id j18si615437igt.3.2015.05.18.08.27.43 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 18 May 2015 08:27:43 -0700 (PDT) Date: Mon, 18 May 2015 08:27:37 -0700 From: Guenter Roeck To: "Opensource [Steve Twiss]" Cc: LINUXKERNEL , LINUXWATCHDOG , Wim Van Sebroeck , Alessandro Zummo , DEVICETREE , David Dajun Chen , Dmitry Torokhov , Ian Campbell , Kumar Gala , LINUXINPUT , Lee Jones , Liam Girdwood , Mark Brown , Mark Rutland , Pawel Moll , RTCLINUX , Rob Herring , Samuel Ortiz , Support Opensource Subject: [rtc-linux] Re: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver Message-ID: <20150518152737.GA14403@roeck-us.net> References: <6a51f163b99edfad9165ad29609abb072dbaa2b7.1431621833.git.stwiss.opensource@diasemi.com> <55555639.8090505@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7014B22B63A@SW-EX-MBX02.diasemi.com> <5555ED4F.5070003@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7014B22B6E2@SW-EX-MBX02.diasemi.com> <20150515202005.GA23133@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7014B22B8C8@SW-EX-MBX02.diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7014B22B8C8@SW-EX-MBX02.diasemi.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Mon, May 18, 2015 at 02:15:01PM +0000, Opensource [Steve Twiss] wrote: > On 15 May 2015 21:20 Guenter Roeck, > > > > > > + > > > > > +/* E_WDG_WARN interrupt handler */ > > > > > +static irqreturn_t da9062_wdt_wdg_warn_irq_handler(int irq, void*data) > > > > > +{ > > > > > + struct da9062_watchdog *wdt = data; > > > > > + > > > > > + dev_notice(wdt->hw->dev, "Watchdog timeout warning trigger.\n"); > > > > > + return IRQ_HANDLED; > > > > > +} > > > > > + > > > > > > On 15 May 2015 13:58 Guenter Roeck wrote: > > > > > > [...] > > > > > > > >>> + > > > > >>> + irq = platform_get_irq_byname(pdev, "WDG_WARN"); > > > > >>> + if (irq < 0) { > > > > >>> + dev_err(wdt->hw->dev, "Failed to get IRQ.\n"); > > > > >>> + ret = irq; Hi Steve, Since the interrupt is optional, the driver should also not fail to load if no interrupt is assigned to it in the first place. On a separate note, there was a comment stating that the da9062 watchdog is identical to the da9063 watchdog. If so, why can't you just use the da9063 watchdog driver ? Thanks, Guenter -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:45904 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752762AbbERP1m (ORCPT ); Mon, 18 May 2015 11:27:42 -0400 Date: Mon, 18 May 2015 08:27:37 -0700 From: Guenter Roeck To: "Opensource [Steve Twiss]" Cc: LINUXKERNEL , LINUXWATCHDOG , Wim Van Sebroeck , Alessandro Zummo , DEVICETREE , David Dajun Chen , Dmitry Torokhov , Ian Campbell , Kumar Gala , LINUXINPUT , Lee Jones , Liam Girdwood , Mark Brown , Mark Rutland , Pawel Moll , RTCLINUX , Rob Herring , Samuel Ortiz , Support Opensource Subject: Re: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver Message-ID: <20150518152737.GA14403@roeck-us.net> References: <6a51f163b99edfad9165ad29609abb072dbaa2b7.1431621833.git.stwiss.opensource@diasemi.com> <55555639.8090505@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7014B22B63A@SW-EX-MBX02.diasemi.com> <5555ED4F.5070003@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7014B22B6E2@SW-EX-MBX02.diasemi.com> <20150515202005.GA23133@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7014B22B8C8@SW-EX-MBX02.diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7014B22B8C8@SW-EX-MBX02.diasemi.com> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Mon, May 18, 2015 at 02:15:01PM +0000, Opensource [Steve Twiss] wrote: > On 15 May 2015 21:20 Guenter Roeck, > > > > > > + > > > > > +/* E_WDG_WARN interrupt handler */ > > > > > +static irqreturn_t da9062_wdt_wdg_warn_irq_handler(int irq, void*data) > > > > > +{ > > > > > + struct da9062_watchdog *wdt = data; > > > > > + > > > > > + dev_notice(wdt->hw->dev, "Watchdog timeout warning trigger.\n"); > > > > > + return IRQ_HANDLED; > > > > > +} > > > > > + > > > > > > On 15 May 2015 13:58 Guenter Roeck wrote: > > > > > > [...] > > > > > > > >>> + > > > > >>> + irq = platform_get_irq_byname(pdev, "WDG_WARN"); > > > > >>> + if (irq < 0) { > > > > >>> + dev_err(wdt->hw->dev, "Failed to get IRQ.\n"); > > > > >>> + ret = irq; Hi Steve, Since the interrupt is optional, the driver should also not fail to load if no interrupt is assigned to it in the first place. On a separate note, there was a comment stating that the da9062 watchdog is identical to the da9063 watchdog. If so, why can't you just use the da9063 watchdog driver ? Thanks, Guenter