Re: [PATCH 1/3] gdbserverproxy-module-drv: Add version 1.1.0

[Denys Dmytriyenko <denys@ti.com>]

On Mon, May 18, 2015 at 01:54:51PM -0400, Jacob Stiffler wrote:
> 
> 
> On 5/18/2015 1:40 PM, Denys Dmytriyenko wrote:
> >On Mon, May 18, 2015 at 01:32:54PM -0400, Jacob Stiffler wrote:
> >>Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> >>---
> >>  recipes-devtools/gdbc6x/gdbc6x.inc                 |    9 ++++++
> >>  .../gdbc6x/gdbserverproxy-module-drv_git.bb        |   31 ++++++++++++++++++++
> >>  2 files changed, 40 insertions(+)
> >>  create mode 100644 recipes-devtools/gdbc6x/gdbc6x.inc
> >>  create mode 100644 recipes-devtools/gdbc6x/gdbserverproxy-module-drv_git.bb
> >>
> >>diff --git a/recipes-devtools/gdbc6x/gdbc6x.inc b/recipes-devtools/gdbc6x/gdbc6x.inc
> >>new file mode 100644
> >>index 0000000..ecdc11e
> >>--- /dev/null
> >>+++ b/recipes-devtools/gdbc6x/gdbc6x.inc
> >>@@ -0,0 +1,9 @@
> >>+BRANCH = "master"
> >>+
> >>+PV = "1.1.0"
> >>+INC_PR = "r0"
> >>+
> >>+# This corresponds to version 1.1.0
> >>+SRCREV = "1ab06f8bcfe7540754558bac331a0312c4b59142"
> >>+
> >>+SRC_URI = "git://git.ti.com/sdo-emu/gdbc6x.git;protocol=git;branch=${BRANCH}"
> >>diff --git a/recipes-devtools/gdbc6x/gdbserverproxy-module-drv_git.bb b/recipes-devtools/gdbc6x/gdbserverproxy-module-drv_git.bb
> >>new file mode 100644
> >>index 0000000..2b02236
> >>--- /dev/null
> >>+++ b/recipes-devtools/gdbc6x/gdbserverproxy-module-drv_git.bb
> >>@@ -0,0 +1,31 @@
> >>+DESCRIPTION="Interface for GDB to commincate witha TI C66X DSP"
> >>+
> >>+LICENSE = "GPLv2"
> >>+LIC_FILES_CHKSUM = "file://COPYING.txt;md5=75859989545e37968a99b631ef42722e"
> >>+
> >>+include gdbc6x.inc
> >>+
> >>+COMPATIBLE_MACHINE = "dra7xx"
> >>+PACKAGE_ARCH = "${MACHINE_ARCH}"
> >>+
> >>+# This package builds a kernel module, use kernel PR as base and append a local
> >>+MACHINE_KERNEL_PR_append = "a+gitr${SRCPV}"
> >>+PR = "${MACHINE_KERNEL_PR}"
> >>+
> >>+PLATFORM = ""
> >>+PLATFORM_dra7xx = "DRA7xx_PLATFORM"
> >>+
> >>+EXTRA_OEMAKE = "PLATFORM=${PLATFORM}"
> >>+
> >>+S = "${WORKDIR}/git/kernel_module/gdbproxy-mod"
> >>+
> >>+module_autoload_gdbserverproxy = "gdbserverproxy"
> >>+
> >>+inherit module
> >>+
> >>+do_configure[noexec] = "1"
> >>+do_qa_configure[noexec] = "1"
> >What's the need for the above?
> >
> 
> All three of these gdbc6x recipes use the same source. Without this
> there is a QA error due to the file "git/gdbc6x/intl/configure.ac",
> which is outside of the ${S} directory. The error is the following:
> 
> ERROR: virtual/gettext required but not in DEPENDS for file /media/hdd-1TB/jake/git/oe-layersetup_patches/build/arago-tmp-external-linaro-toolchain/work/am57xx_evm-linux-gnueabi/gdbserver-c6x/1.1.0-r0.1/git/gdbc6x/intl/configure.ac.
> Missing inherit gettext?
> ERROR: Function failed: do_qa_configure
> 
> 
> Is there a better way to handle this?

Looks like there's no INSANE_SKIP for this check, but there's a way to bypass 
it w/o disabling all other QA checks:

EXTRA_OECONF = "--disable-nls"
do_configure() {
	:
}

Just add some comment above that block explaining why it's needed, something 
about erroneously tripping QA check for gettext due to unused configure.ac 
file...


> >>+CREATE_SRCIPK = "1"
> >>+SRCIPK_INSTALL_DIR = "board-support/extra-drivers/${PN}-${PV}"
> >>+SRCIPK_PACKAGE_ARCH = "${MACHINE_ARCH}"
> >This is not the right place for these^^ either.
> >
> 
> This was an oversight, and I'll remove in the next version.
>