From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/bridge: use flags argument of devm_gpiod_get to set direction Date: Tue, 19 May 2015 10:06:54 +0200 Message-ID: <20150519080653.GD1255@ulmo.nvidia.com> References: <1432019029-9654-1-git-send-email-u.kleine-koenig@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1637089229==" Return-path: Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 04B7C6E5FF for ; Tue, 19 May 2015 01:07:03 -0700 (PDT) In-Reply-To: <1432019029-9654-1-git-send-email-u.kleine-koenig@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Alexandre Courbot , Vincent Palatin , dri-devel@lists.freedesktop.org, kernel@pengutronix.de List-Id: dri-devel@lists.freedesktop.org --===============1637089229== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UfEAyuTBtIjiZzX6" Content-Disposition: inline --UfEAyuTBtIjiZzX6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 19, 2015 at 09:03:49AM +0200, Uwe Kleine-K=C3=B6nig wrote: > Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) > which appeared in v3.17-rc1, the gpiod_get* functions take an additional > parameter that allows to specify direction and initial value for output. >=20 > Use this to simplify the driver. Furthermore this is one caller less > that stops us making the flags argument to gpiod_get*() mandatory. >=20 > Fixes: b2ea8772799d ("drm/bridge: Add I2C based driver for ps8622/ps8625 = bridge") There's no need for this. The patch refactors code, but it doesn't fix anything. Including a "Fixes:" line will cause people to pick this up for stable releases, which I don't think is warranted in this case. I've applied the patch with the "Fixes:" line removed. Thanks, Thierry --UfEAyuTBtIjiZzX6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVWu8cAAoJEN0jrNd/PrOhE7kP/ikHw+AQhoksbaHlISddlzcg zKippDJnr7daHPr3IFUm42XGolHbLpaRx4SuPLByvOOsAWyroj+pI5phUgznVc2p iRjZ2sTKjwP3DmRqs6zwwMWErwLxy3/w8oNmSQJ0fO0sg07wW34pUdQs5Nj1YvN0 bYe+iS/GoixmlvUpLXG9mDjgFNxTsmZHCSJrew1G4SPm3bjBdiBowsQXpycP/H/W x5Juf4B+AUj3LtEYKeFAsIMEHNC8b0+M1mZKy0MNyMFs2BMq2bNjV/U9KBnT8OE4 u1++p/zFKeqamnR+zBqatSDaXMjhL4aautU7FqOXxvCGg/SJ9mRdJoOlgorxblZm oKq/5LEBYmhK+p6RetLn3Xto9MpDYqnE4r8mhDgDf+kgqndZ83dpbSsgsii+UuUy /qxvi9iE7N4YR7aNKnlJwoeqnnjPXX83+RtZT6uf6P8erZjy6QICHi8VDJqHD2Y4 NA0Xj2YNtgxwR+pxs0J6YvCFSzld0ok7DpgyuvOZ/GxVM1DyWFXsS3XR7l7rk0Qp NNGdEOZXFjenss3/VGkbKnnQAaa+ylyereZPem1FMjCa+tPmI+2MHxC7wXJV5R4D 10NKw5FSAqaQ97ZlwC26rkKQKfov7NRDTZPRFvcCI7apTzl9sOValAd2G7uV+p4N Ec7M0tMmcLLOcTjC4KFe =Ze6+ -----END PGP SIGNATURE----- --UfEAyuTBtIjiZzX6-- --===============1637089229== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1637089229==--