From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/bridge/ptn3460: use flags argument of devm_gpiod_get to set direction Date: Tue, 19 May 2015 10:09:06 +0200 Message-ID: <20150519080904.GE1255@ulmo.nvidia.com> References: <1432019756-15132-1-git-send-email-u.kleine-koenig@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0476939802==" Return-path: Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com [216.228.121.64]) by gabe.freedesktop.org (Postfix) with ESMTP id 029606E218 for ; Tue, 19 May 2015 01:09:16 -0700 (PDT) In-Reply-To: <1432019756-15132-1-git-send-email-u.kleine-koenig@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Alexandre Courbot , dri-devel@lists.freedesktop.org, kernel@pengutronix.de, Ajay Kumar List-Id: dri-devel@lists.freedesktop.org --===============0476939802== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jKBxcB1XkHIR0Eqt" Content-Disposition: inline --jKBxcB1XkHIR0Eqt Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 19, 2015 at 09:15:56AM +0200, Uwe Kleine-K=C3=B6nig wrote: > Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) > which appeared in v3.17-rc1, the gpiod_get* functions take an additional > parameter that allows to specify direction and initial value for output. >=20 > Use this to simplify the driver. Furthermore this is one caller less > that stops us making the flags argument to gpiod_get*() mandatory. >=20 > Fixes: af478d8823a7 ("drm/bridge: ptn3460: use gpiod interface") > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- > drivers/gpu/drm/bridge/ptn3460.c | 23 +++++++---------------- > 1 file changed, 7 insertions(+), 16 deletions(-) Applied without the "Fixes:" line. Thanks, Thierry --jKBxcB1XkHIR0Eqt Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVWu+gAAoJEN0jrNd/PrOhcnUP/jhlTQdxEzIbuusZju+rNUS6 20yJ16aPq/XsxJbtlFmbC0vHvG68E77AsUpMJ/qm+tEnwFYZ8PxMp8VFqjIt3cft iJk0tk7GgWxrkJ8fILvVMKzSMQBkPiubxP8EOoftpOqHJojoZpfnBQZnbMjPmgMw OyCarM00ud9rhcd5E0dcKj8nQFmMQ130DeJ4A/Wn748U7/RJjoEzaRBZqas9M7XB ZRy9m+2XhIvPNBI5LE3G6lc62VUlso64NQVexznUr+ghRktL7SCXpq+YXSw1E8TG lIMM1BHOyDCBHvEVt+MkL7nl/OToJaIbF8+DXkBV9N4whOn64eQiyjPkRc9Jg/M0 MOIjaKvESLzIkhNCyeyEpQfDZINrQEH+ny7mweEQpkgHDmNjtW+QbqCzkt5ruCdR PDxsm840oAceydyzUo/+MGrqkIPKOaBn8yJsEAN4tun2HkcCf5lEP3tI3cRnhyyX FybR/2iHNEDQbV7F5gt3B/R44R64PfOF73GHcVmpgRK7l2tRZ5MquD1WzFxW+Rg7 P5x3zh/NDycFc4xxDuVEniTiopZQJemb79i0vzlS73ZxypelCgbdzTXY8LkTgpj5 q5XDesRFAJLEp5CDMXH7L+lhVvYNsFcQOWwMF3ymaBxPQ5il+qipde+8zUJYPzAh I6k0d2NxBt8W3c82hEpi =yhZE -----END PGP SIGNATURE----- --jKBxcB1XkHIR0Eqt-- --===============0476939802== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0476939802==--