All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 08/12] arm64: psci: remove ACPI coupling
Date: Tue, 19 May 2015 10:18:56 +0100	[thread overview]
Message-ID: <20150519091856.GA1035@leverpostej> (raw)
In-Reply-To: <555AF703.4050702@linaro.org>

On Tue, May 19, 2015 at 09:40:35AM +0100, Hanjun Guo wrote:
> > diff --git a/arch/arm64/include/asm/psci.h b/arch/arm64/include/asm/psci.h
> > index 2454bc5..b5d4c1d 100644
> > --- a/arch/arm64/include/asm/psci.h
> > +++ b/arch/arm64/include/asm/psci.h
> > @@ -14,7 +14,14 @@
> >   #ifndef __ASM_PSCI_H
> >   #define __ASM_PSCI_H
> >
> > -int psci_dt_init(void);
> > -int psci_acpi_init(void);
> > +int __init psci_dt_init(void);
> > +
> > +#ifdef CONFIG_ACPI
> > +int __init psci_acpi_init(void);
> > +bool __init acpi_psci_present(void);
> > +bool __init acpi_psci_use_hvc(void);
> 
> really some nit, do we need __init for function declaration?

Given that it's used for function declarations in init.h and other
places, I believe it is best practice. Even if not strictly necessary it
makes clear to the casual read when a function may be called.

> 
> other than that,
> 
> Acked-by: Hanjun Guo <hanjun.guo@linaro.org>

Cheers!

Mark.

  reply	other threads:[~2015-05-19  9:18 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18 10:38 [PATCHv2 00/12] arm/arm64: Unify PSCI client support Mark Rutland
2015-05-18 10:38 ` [PATCHv2 01/12] arm/arm64: kvm: add missing PSCI include Mark Rutland
2015-05-19  3:37   ` Hanjun Guo
2015-05-18 10:38 ` [PATCHv2 02/12] arm64: smp_plat: add get_logical_index Mark Rutland
2015-05-18 17:09   ` Catalin Marinas
2015-05-18 17:55     ` Mark Rutland
2015-05-19  3:47       ` Hanjun Guo
2015-05-19  8:31       ` Catalin Marinas
2015-05-19  9:10         ` Mark Rutland
2015-05-18 10:38 ` [PATCHv2 03/12] arm64: smp: consistently use error codes Mark Rutland
2015-05-18 17:21   ` Catalin Marinas
2015-05-19  8:17   ` Hanjun Guo
2015-05-18 10:38 ` [PATCHv2 04/12] arm64: psci: remove unnecessary id indirection Mark Rutland
2015-05-18 17:28   ` Catalin Marinas
2015-05-19  8:21   ` Hanjun Guo
2015-05-18 10:38 ` [PATCHv2 05/12] arm64: psci: support unsigned return values Mark Rutland
2015-05-18 17:29   ` Catalin Marinas
2015-05-19  8:25   ` Hanjun Guo
2015-05-18 10:38 ` [PATCHv2 06/12] arm64: psci: account for Trusted OS instances Mark Rutland
2015-05-18 17:33   ` Catalin Marinas
2015-05-18 10:38 ` [PATCHv2 07/12] arm64: psci: kill psci_power_state Mark Rutland
2015-05-18 17:36   ` Catalin Marinas
2015-05-18 18:11     ` Mark Rutland
2015-05-18 10:38 ` [PATCHv2 08/12] arm64: psci: remove ACPI coupling Mark Rutland
2015-05-18 17:38   ` Catalin Marinas
2015-05-19  8:40   ` Hanjun Guo
2015-05-19  9:18     ` Mark Rutland [this message]
2015-05-18 10:38 ` [PATCHv2 09/12] arm64: psci: factor invocation code to drivers Mark Rutland
2015-05-18 17:40   ` Catalin Marinas
2015-05-19  8:46   ` Hanjun Guo
2015-05-18 10:38 ` [PATCHv2 10/12] drivers: psci: support native SMC{32,64} calls Mark Rutland
2015-05-18 17:43   ` Catalin Marinas
2015-05-18 17:49     ` Mark Rutland
2015-05-18 10:38 ` [PATCHv2 11/12] ARM: migrate to common PSCI client code Mark Rutland
2015-05-18 17:45   ` Catalin Marinas
2015-05-18 10:38 ` [PATCHv2 12/12] MAINTAINERS: add PSCI entry Mark Rutland
2015-05-18 17:45   ` Catalin Marinas
2015-05-18 17:49 ` [PATCHv2 00/12] arm/arm64: Unify PSCI client support Catalin Marinas
2015-05-19  9:03   ` Lorenzo Pieralisi
2015-05-19  9:32     ` Mark Rutland
2015-05-19 15:20       ` Catalin Marinas
2015-05-19  8:54 ` Hanjun Guo
2015-05-19  9:33   ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150519091856.GA1035@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.