From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755647AbbESLSy (ORCPT ); Tue, 19 May 2015 07:18:54 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:21805 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755603AbbESLSw (ORCPT ); Tue, 19 May 2015 07:18:52 -0400 Date: Tue, 19 May 2015 14:18:27 +0300 From: Dan Carpenter To: Sudip Mukherjee Cc: Greg KH , One Thousand Gnomes , Jean Delvare , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 WIP 2/5] staging: panel: use new parport device model Message-ID: <20150519111827.GM22558@mwanda> References: <1430907377-17147-1-git-send-email-sudipm.mukherjee@gmail.com> <1430907377-17147-2-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430907377-17147-2-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 06, 2015 at 03:46:14PM +0530, Sudip Mukherjee wrote: > converted to use the new device-model parallel port. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/panel/panel.c | 20 +++++++++++++++----- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c > index 1d8ed8b..772a82a 100644 > --- a/drivers/staging/panel/panel.c > +++ b/drivers/staging/panel/panel.c > @@ -2188,6 +2188,18 @@ static struct notifier_block panel_notifier = { > 0 > }; > > +static int panel_probe(struct pardevice *par_dev) > +{ > + if (strcmp(par_dev->name, "panel")) > + return -ENODEV; > + return 0; > +} > + > +struct pardev_cb panel_cb = { > + .flags = 0, /*PARPORT_DEV_EXCL */ I don't understand this comment. PARPORT_DEV_EXCL is BIT(2). Update: Oh, I see this comment is just copied from the earlier code and probably means that it maybe should be set to PARPORT_DEV_EXCL. Just put something like this: .flags = 0, /* should be PARPORT_DEV_EXCL? */ regards, dan carpenter