From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Hannes Reinecke <hare@suse.de>, Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org,
"linux-kernel@vger.kernel.org Sergey Senozhatsky"
<sergey.senozhatsky@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: READ LOG DMA EXT failed, trying unqueued
Date: Tue, 19 May 2015 21:00:17 +0900 [thread overview]
Message-ID: <20150519120017.GA390@swordfish> (raw)
In-Reply-To: <20150519113320.GA498@swordfish>
On (05/19/15 20:33), Sergey Senozhatsky wrote:
> my laptop doesn't boot anymore, spinning in "READ LOG DMA EXT failed, trying unqueued".
> any reason it loops forever?
>
perhaps something like this?
8<-----8<-----
>From 826eb3644e7d4b1f66a898c63865f217fb82f1f9 Mon Sep 17 00:00:00 2001
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Date: Tue, 19 May 2015 20:54:18 +0900
Subject: [PATCH] ata: do not retry ata_read_log_page() forever
Do not spin on failing ata_exec_internal() forever, make a one shot
ATA_HORKAGE_NO_NCQ_LOG retry.
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
drivers/ata/libata-eh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index f093174..20f1549 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -1531,7 +1531,7 @@ retry:
err_mask = ata_exec_internal(dev, &tf, NULL, DMA_FROM_DEVICE,
buf, sectors * ATA_SECT_SIZE, 0);
- if (err_mask && dma) {
+ if (err_mask && dma && !(dev->horkage & ATA_HORKAGE_NO_NCQ_LOG)) {
dev->horkage |= ATA_HORKAGE_NO_NCQ_LOG;
ata_dev_warn(dev, "READ LOG DMA EXT failed, trying unqueued\n");
goto retry;
--
2.4.1.168.g1ea28e1
prev parent reply other threads:[~2015-05-19 12:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 11:33 READ LOG DMA EXT failed, trying unqueued Sergey Senozhatsky
2015-05-19 11:49 ` Martin K. Petersen
2015-05-19 12:05 ` Sergey Senozhatsky
2015-05-19 12:10 ` Sergey Senozhatsky
2015-05-19 12:00 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519120017.GA390@swordfish \
--to=sergey.senozhatsky@gmail.com \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.