From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 0/3] generic: fixes for different allocation behaviours
Date: Tue, 19 May 2015 08:23:51 -0400 [thread overview]
Message-ID: <20150519122351.GA40561@bfoster.bfoster> (raw)
In-Reply-To: <1431568417-6462-1-git-send-email-david@fromorbit.com>
On Thu, May 14, 2015 at 11:53:34AM +1000, Dave Chinner wrote:
> Hi folks,
>
> These 3 patches address failures I found when testing the XFS DAX
> functionality. DAX disables delayed allocation on XFS, so the size
> of the buffer in the write() call determines the size of the
> allocation that is done. Hence tests that expect a specific extent
> layout need to do IO in buffers as large as the extent size they
> expect to be created.
>
> The other side of this is that some tests also expect partial writes
> to occur, which happened as a side effect of buffered writes being
> broken down into PAGE_SIZE chunks. With DAX, that does not happen -
> the writes tend to either succeed or fail completely, especially if
> it is an ENOSPC condition that is ocurring.
>
> HEnce these patches address these test assumptions, and now they
> work correctly and pass on both DAX and non-DAX filesystems.
>
All look fine to me:
Reviewed-by: Brian Foster <bfoster@redhat.com>
> Cheers,
>
> Dave.
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-05-19 12:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 1:53 [PATCH 0/3] generic: fixes for different allocation behaviours Dave Chinner
2015-05-14 1:53 ` [PATCH 1/3] generic/018: use xfs_io and larger buffers for writes Dave Chinner
2015-05-14 1:53 ` [PATCH 2/3] generic/223, xfs/203: IO is not well aligned Dave Chinner
2015-05-14 1:53 ` [PATCH 3/3] generic/275: writes may not partially succeed Dave Chinner
2015-05-19 12:23 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519122351.GA40561@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.