From: Thierry Reding <thierry.reding@gmail.com>
To: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
Cc: linux-pwm@vger.kernel.org,
Naidu Tellapati <naidu.tellapati@imgtec.com>,
James Hartley <james.hartley@imgtec.com>,
linux-mips@linux-mips.org, sai.masarapu@imgtec.com,
arul.ramasamy@imgtec.com
Subject: Re: [PATCH v2] pwm: img: Impose upper and lower timebase steps value
Date: Tue, 19 May 2015 16:15:24 +0200 [thread overview]
Message-ID: <20150519141522.GA26748@ulmo.nvidia.com> (raw)
In-Reply-To: <555778D3.4030607@imgtec.com>
[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]
On Sat, May 16, 2015 at 02:05:23PM -0300, Ezequiel Garcia wrote:
> Thierry,
>
> On 05/08/2015 06:47 PM, Ezequiel Garcia wrote:
> > From: Naidu Tellapati <naidu.tellapati@imgtec.com>
> >
> > The PWM hardware on Pistachio platform has a maximum timebase steps
> > value to 255. To fix it, let's introduce a compatible-specific
> > data structure to contain the SoC-specific details and use it to
> > specify a maximum timebase.
> >
> > Also, let's limit the minimum timebase to 16 steps, to allow a sane
> > range of duty cycle steps.
> >
> > Fixes: 277bb6a29e00 ("pwm: Imagination Technologies PWM DAC driver")
> > Signed-off-by: Naidu Tellapati <naidu.tellapati@imgtec.com>
> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
> > ---
> > This patch is needed for the pwm-img to work properly, so it should be
> > pushed as a v4.1-rc fix.
> >
>
> Any chance you push this patch as a fix for v4.1?
Pull request sent now. In the future it'd be nice to make fix patches
smaller than this and leave the refactoring to a subsequent patch for
inclusion in the next release.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-05-19 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 21:59 [PATCH] pwm: img: Change min and max timebase steps value Ezequiel Garcia
2015-05-07 21:59 ` Ezequiel Garcia
2015-05-08 21:47 ` [PATCH v2] pwm: img: Impose upper and lower " Ezequiel Garcia
2015-05-08 21:47 ` Ezequiel Garcia
2015-05-16 17:05 ` Ezequiel Garcia
2015-05-16 17:05 ` Ezequiel Garcia
2015-05-19 14:15 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519141522.GA26748@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=arul.ramasamy@imgtec.com \
--cc=ezequiel.garcia@imgtec.com \
--cc=james.hartley@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-pwm@vger.kernel.org \
--cc=naidu.tellapati@imgtec.com \
--cc=sai.masarapu@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.