From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id t6si30290wiz.0.2015.05.19.15.11.11 for ; Tue, 19 May 2015 15:11:11 -0700 (PDT) Date: Wed, 20 May 2015 00:11:09 +0200 From: Alexandre Belloni To: Jingoo Han Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Igor Grinberg' Subject: [rtc-linux] Re: [V2] rtc: rtc-v3020: use gpio_request_array() Message-ID: <20150519221109.GD3338@piout.net> References: <008a01ce10a3$02d28db0$0877a910$%han@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <008a01ce10a3$02d28db0$0877a910$%han@samsung.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 22/02/2013 at 11:19:15 +0900, Jingoo Han wrote : > Using gpio_request_array()/gpio_free_array() can make the code > simpler because it can set the direction and initial value > in one shot and the for loop is unnecessary. > > Also, struct v3020_gpio is removed, because the struct v3020_gpio > is replaced with struct gpio. > > Signed-off-by: Jingoo Han > --- > Changes since v1: > - Replace gpio_request_one() with gpio_request_array() > > drivers/rtc/rtc-v3020.c | 37 ++++++++++++------------------------- > 1 files changed, 12 insertions(+), 25 deletions(-) > Applied with the change suggested by Igor, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752242AbbESWLS (ORCPT ); Tue, 19 May 2015 18:11:18 -0400 Received: from down.free-electrons.com ([37.187.137.238]:50840 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751117AbbESWLN (ORCPT ); Tue, 19 May 2015 18:11:13 -0400 Date: Wed, 20 May 2015 00:11:09 +0200 From: Alexandre Belloni To: Jingoo Han Cc: linux-kernel@vger.kernel.org, "'Alessandro Zummo'" , rtc-linux@googlegroups.com, "'Igor Grinberg'" Subject: Re: [V2] rtc: rtc-v3020: use gpio_request_array() Message-ID: <20150519221109.GD3338@piout.net> References: <008a01ce10a3$02d28db0$0877a910$%han@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <008a01ce10a3$02d28db0$0877a910$%han@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/02/2013 at 11:19:15 +0900, Jingoo Han wrote : > Using gpio_request_array()/gpio_free_array() can make the code > simpler because it can set the direction and initial value > in one shot and the for loop is unnecessary. > > Also, struct v3020_gpio is removed, because the struct v3020_gpio > is replaced with struct gpio. > > Signed-off-by: Jingoo Han > --- > Changes since v1: > - Replace gpio_request_one() with gpio_request_array() > > drivers/rtc/rtc-v3020.c | 37 ++++++++++++------------------------- > 1 files changed, 12 insertions(+), 25 deletions(-) > Applied with the change suggested by Igor, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com