All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Welling <mwelling@ieee.org>
To: Greg Wilson-Lindberg <GWilson@sakuraus.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: BBB touch screen and ADC interactions
Date: Tue, 19 May 2015 19:34:35 -0500	[thread overview]
Message-ID: <20150520003435.GA16055@deathray> (raw)
In-Reply-To: <782E3A02C2EB2347BEA6DEA69DC7AB86021D3C87D47E@sfamail.SAKURAUS.LOCAL>

On Tue, May 19, 2015 at 05:16:46PM -0700, Greg Wilson-Lindberg wrote:
> 
> I would be happy to test the patch, better than what I was going to try.
> 
> -Greg

Below is the simple workaround patch that I used to eliminate the repeated
release events that were occurring without touching the screen.

See if it helps.

diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
index 191a1b8..f876097 100644
--- a/drivers/input/touchscreen/ti_am335x_tsc.c
+++ b/drivers/input/touchscreen/ti_am335x_tsc.c
@@ -281,13 +281,11 @@ static irqreturn_t titsc_irq(int irq, void *dev)
 	if (status & IRQENB_PENUP) {
 		fsm = titsc_readl(ts_dev, REG_ADCFSM);
 		if (fsm == ADCFSM_STEPID) {
-			ts_dev->pen_down = false;
 			input_report_key(input_dev, BTN_TOUCH, 0);
 			input_report_abs(input_dev, ABS_PRESSURE, 0);
 			input_sync(input_dev);
-		} else {
-			ts_dev->pen_down = true;
 		}
+		ts_dev->pen_down = false;
 		irqclr |= IRQENB_PENUP;
 	}
 

  reply	other threads:[~2015-05-20  0:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 23:23 BBB touch screen and ADC interactions Greg Wilson-Lindberg
2015-05-13  1:11 ` Michael Welling
2015-05-14 17:00   ` Greg Wilson-Lindberg
2015-05-19 23:30     ` Michael Welling
2015-05-19 23:56       ` Greg Wilson-Lindberg
2015-05-20  0:13         ` mwelling
2015-05-20  0:16           ` Greg Wilson-Lindberg
2015-05-20  0:34             ` Michael Welling [this message]
2015-05-20 21:54               ` Greg Wilson-Lindberg
2015-05-20 22:14                 ` Michael Welling
2015-05-20 22:41                   ` Greg Wilson-Lindberg
2015-05-20 23:04                     ` Michael Welling
2015-05-26 17:42                       ` Michael Welling
2015-05-26 18:04                         ` Greg Wilson-Lindberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150520003435.GA16055@deathray \
    --to=mwelling@ieee.org \
    --cc=GWilson@sakuraus.com \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.