All of lore.kernel.org
 help / color / mirror / Atom feed
From: Torsten Duwe <duwe@lst.de>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Jiri Kosina <jkosina@suse.cz>,
	ppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ppc64 ftrace: mark data_access callees "notrace" (pt.1)
Date: Wed, 20 May 2015 11:03:25 +0200	[thread overview]
Message-ID: <20150520090325.GA11577@lst.de> (raw)
In-Reply-To: <1432006027.8339.3.camel@ellerman.id.au>

On Tue, May 19, 2015 at 01:27:07PM +1000, Michael Ellerman wrote:
> On Mon, 2015-05-18 at 14:29 +0200, Jiri Kosina wrote:
> > 
> > ftrace already handles recursion protection by itself (depending on the 
> > per-ftrace-ops FTRACE_OPS_FL_RECURSION_SAFE flag).
> 
> OK, so I wonder why that's not working for us?

IIRC a data access fault happens just before that flag is looked at ;-)

I'm now thinking about a hybrid solution: mark the most critical functions
"notrace", especially those directly involved with MMU loading, and add
a per-thread flag to catch the not-so-obvious cases.

	Torsten

  parent reply	other threads:[~2015-05-20  9:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13 16:11 [PATCH] ppc64 ftrace: mark data_access callees "notrace" (pt.1) Torsten Duwe
2015-05-15  1:34 ` Michael Ellerman
2015-05-15  8:45   ` Torsten Duwe
2015-05-16  8:05     ` Torsten Duwe
2015-05-18 12:29       ` Jiri Kosina
2015-05-18 12:29         ` Jiri Kosina
2015-05-19  3:27         ` Michael Ellerman
2015-05-19  3:27           ` Michael Ellerman
2015-05-19  9:52           ` Jiri Kosina
2015-05-19  9:52             ` Jiri Kosina
2015-06-03 13:02             ` [PATCH 0/4] ppc64 ftrace implementation Torsten Duwe
2015-06-03 13:08               ` [PATCH 1/4] " Torsten Duwe
2015-06-08 15:30                 ` Steven Rostedt
2015-06-08 15:57                   ` Torsten Duwe
2015-06-03 13:10               ` [PATCH 2/4] ppc64 ftrace configuration Torsten Duwe
2015-06-03 13:15               ` [PATCH 3/4] ppc64 ftrace: spare early boot and low level code Torsten Duwe
2015-06-03 13:22               ` [PATCH 4/4] ppc64 ftrace recursion protection Torsten Duwe
2015-05-20  9:03           ` Torsten Duwe [this message]
2015-05-26 14:34             ` [PATCH] ppc64 ftrace: mark data_access callees "notrace" (pt.1) Torsten Duwe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150520090325.GA11577@lst.de \
    --to=duwe@lst.de \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.