From: Darren Hart <dvhart@infradead.org>
To: "qipeng.zha" <qipeng.zha@intel.com>
Cc: platform-driver-x86@vger.kernel.org, fei.yang@intel.com,
huiquan.zhong@intel.com, jason.cj.chen@intel.com,
qi.zheng@intel.com
Subject: Re: [PATCH v2] platform:x86: add Intel Broxton PMC IPC driver
Date: Wed, 20 May 2015 11:28:53 +0200 [thread overview]
Message-ID: <20150520092853.GC22037@vmdeb7> (raw)
In-Reply-To: <1431958130-75816-1-git-send-email-qipeng.zha@intel.com>
On Mon, May 18, 2015 at 10:08:50PM +0800, qipeng.zha wrote:
> From: "qipeng.zha" <qipeng.zha@intel.com>
>
> This driver provides support for PMC control on Broxton platforms,
> PMC is ARC processor which defined some IPC commands for communication
> with other entities running in IA
>
> Signed-off-by: qipeng.zha <qipeng.zha@intel.com>
Please run through checkpatch.pl and correct errors.
Compilation fails:
CC [M] drivers/platform/x86/intel_pmc_ipc.o
drivers/platform/x86/intel_pmc_ipc.c:214:5: error: redefinition of ‘intel_pmc_ipc_simple_command’
int intel_pmc_ipc_simple_command(int cmd, int sub)
^
In file included from drivers/platform/x86/intel_pmc_ipc.c:32:0:
./arch/x86/include/asm/intel_pmc_ipc.h:63:19: note: previous definition of ‘intel_pmc_ipc_simple_command’ was here
static inline int intel_pmc_ipc_simple_command(int cmd, int sub)
^
drivers/platform/x86/intel_pmc_ipc.c:242:5: error: redefinition of ‘intel_pmc_ipc_raw_cmd’
int intel_pmc_ipc_raw_cmd(u32 cmd, u32 sub, u8 *in, u32 inlen, u32 *out,
^
In file included from drivers/platform/x86/intel_pmc_ipc.c:32:0:
./arch/x86/include/asm/intel_pmc_ipc.h:68:19: note: previous definition of ‘intel_pmc_ipc_raw_cmd’ was here
static inline int intel_pmc_ipc_raw_cmd(u32 cmd, u32 sub, u8 *in, u32 inlen,
^
drivers/platform/x86/intel_pmc_ipc.c:286:5: error: redefinition of ‘intel_pmc_ipc_command’
int intel_pmc_ipc_command(u32 cmd, u32 sub, u8 *in, u32 inlen,
^
In file included from drivers/platform/x86/intel_pmc_ipc.c:32:0:
./arch/x86/include/asm/intel_pmc_ipc.h:74:19: note: previous definition of ‘intel_pmc_ipc_command’ was here
static inline int intel_pmc_ipc_command(u32 cmd, u32 sub, u8 *in, u32 inlen,
^
scripts/Makefile.build:264: recipe for target 'drivers/platform/x86/intel_pmc_ipc.o' failed
make[1]: *** [drivers/platform/x86/intel_pmc_ipc.o] Error 1
Makefile:1552: recipe for target 'drivers/platform/x86/intel_pmc_ipc.ko' failed
make: *** [drivers/platform/x86/intel_pmc_ipc.ko] Error 2
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-05-20 9:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 14:08 [PATCH v2] platform:x86: add Intel Broxton PMC IPC driver qipeng.zha
2015-05-20 9:28 ` Darren Hart [this message]
2015-05-20 9:42 ` Zha, Qipeng
2015-05-20 10:03 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520092853.GC22037@vmdeb7 \
--to=dvhart@infradead.org \
--cc=fei.yang@intel.com \
--cc=huiquan.zhong@intel.com \
--cc=jason.cj.chen@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qi.zheng@intel.com \
--cc=qipeng.zha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.