From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Subject: Re: [PATCH] drm: drop drm_property_unreference_blob_locked() Date: Wed, 20 May 2015 20:50:09 +0900 Message-ID: <20150520115009.GB1346@swordfish> References: <1432035516-2909-1-git-send-email-sergey.senozhatsky@gmail.com> <87wq03k9mg.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by gabe.freedesktop.org (Postfix) with ESMTP id C4F136E739 for ; Wed, 20 May 2015 04:50:33 -0700 (PDT) Received: by pdbnk13 with SMTP id nk13so66314534pdb.1 for ; Wed, 20 May 2015 04:50:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87wq03k9mg.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: Sergey Senozhatsky , Daniel Stone , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gKDA1LzIwLzE1IDEwOjA5KSwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4gPiBkcm1fcHJvcGVydHlf dW5yZWZlcmVuY2VfYmxvYl9sb2NrZWQoKSBpcyBzdGF0aWMgYW5kIHVudXNlZCwKPiA+IGRyb3Ag aXQuCj4gCj4gaHR0cDovL21pZC5nbWFuZS5vcmcvQ0FQajg3ck1QdGFmZVlOemdYb1ArZngwZEFx aHdhRDdrZG5KZ3FiX3ZkYlB0aU9yWFBnQG1haWwuZ21haWwuY29tCj4gCgpvaCwgb2suIHRoYW5r cy4KCgktc3MKCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogU2VyZ2V5IFNlbm96aGF0c2t5IDxzZXJn ZXkuc2Vub3poYXRza3lAZ21haWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2Ry bV9jcnRjLmMgfCAxOSAtLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDE5 IGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Ny dGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gPiBpbmRleCA0MDU5ZjA2Li42ZTYw ZjcxIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMKPiA+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gPiBAQCAtNDMxMywyNSArNDMxMyw2IEBAIHZv aWQgZHJtX3Byb3BlcnR5X3VucmVmZXJlbmNlX2Jsb2Ioc3RydWN0IGRybV9wcm9wZXJ0eV9ibG9i ICpibG9iKQo+ID4gIEVYUE9SVF9TWU1CT0woZHJtX3Byb3BlcnR5X3VucmVmZXJlbmNlX2Jsb2Ip Owo+ID4gIAo+ID4gIC8qKgo+ID4gLSAqIGRybV9wcm9wZXJ0eV91bnJlZmVyZW5jZV9ibG9iX2xv Y2tlZCAtIFVucmVmZXJlbmNlIGEgYmxvYiBwcm9wZXJ0eSB3aXRoIGJsb2JfbG9jayBoZWxkCj4g PiAtICoKPiA+IC0gKiBEcm9wIGEgcmVmZXJlbmNlIG9uIGEgYmxvYiBwcm9wZXJ0eS4gTWF5IGZy ZWUgdGhlIG9iamVjdC4gVGhpcyBtdXN0IGJlCj4gPiAtICogY2FsbGVkIHdpdGggYmxvYl9sb2Nr IGhlbGQuCj4gPiAtICoKPiA+IC0gKiBAcGFyYW0gZGV2ICBEZXZpY2UgdGhlIGJsb2Igd2FzIGNy ZWF0ZWQgb24KPiA+IC0gKiBAcGFyYW0gYmxvYiBQb2ludGVyIHRvIGJsb2IgcHJvcGVydHkKPiA+ IC0gKi8KPiA+IC1zdGF0aWMgdm9pZCBkcm1fcHJvcGVydHlfdW5yZWZlcmVuY2VfYmxvYl9sb2Nr ZWQoc3RydWN0IGRybV9wcm9wZXJ0eV9ibG9iICpibG9iKQo+ID4gLXsKPiA+IC0JaWYgKCFibG9i KQo+ID4gLQkJcmV0dXJuOwo+ID4gLQo+ID4gLQlEUk1fREVCVUcoIiVwOiBibG9iIElEOiAlZCAo JWQpXG4iLCBibG9iLCBibG9iLT5iYXNlLmlkLCBhdG9taWNfcmVhZCgmYmxvYi0+cmVmY291bnQu cmVmY291bnQpKTsKPiA+IC0KPiA+IC0Ja3JlZl9wdXQoJmJsb2ItPnJlZmNvdW50LCBkcm1fcHJv cGVydHlfZnJlZV9ibG9iKTsKPiA+IC19Cj4gPiAtCj4gPiAtLyoqCj4gPiAgICogZHJtX3Byb3Bl cnR5X3JlZmVyZW5jZV9ibG9iIC0gVGFrZSBhIHJlZmVyZW5jZSBvbiBhbiBleGlzdGluZyBwcm9w ZXJ0eQo+ID4gICAqCj4gPiAgICogVGFrZSBhIG5ldyByZWZlcmVuY2Ugb24gYW4gZXhpc3Rpbmcg YmxvYiBwcm9wZXJ0eS4KPiA+IC0tIAo+ID4gMi40LjEuMTY4LmcxZWEyOGUxCj4gPgo+ID4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IGRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKPiA+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPiAK PiAtLSAKPiBKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIK PiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753215AbbETLuf (ORCPT ); Wed, 20 May 2015 07:50:35 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:33321 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752045AbbETLue (ORCPT ); Wed, 20 May 2015 07:50:34 -0400 Date: Wed, 20 May 2015 20:50:09 +0900 From: Sergey Senozhatsky To: Jani Nikula Cc: Sergey Senozhatsky , David Airlie , Daniel Stone , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: drop drm_property_unreference_blob_locked() Message-ID: <20150520115009.GB1346@swordfish> References: <1432035516-2909-1-git-send-email-sergey.senozhatsky@gmail.com> <87wq03k9mg.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wq03k9mg.fsf@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (05/20/15 10:09), Jani Nikula wrote: > > drm_property_unreference_blob_locked() is static and unused, > > drop it. > > http://mid.gmane.org/CAPj87rMPtafeYNzgXoP+fx0dAqhwaD7kdnJgqb_vdbPtiOrXPg@mail.gmail.com > oh, ok. thanks. -ss > > > > Signed-off-by: Sergey Senozhatsky > > --- > > drivers/gpu/drm/drm_crtc.c | 19 ------------------- > > 1 file changed, 19 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > > index 4059f06..6e60f71 100644 > > --- a/drivers/gpu/drm/drm_crtc.c > > +++ b/drivers/gpu/drm/drm_crtc.c > > @@ -4313,25 +4313,6 @@ void drm_property_unreference_blob(struct drm_property_blob *blob) > > EXPORT_SYMBOL(drm_property_unreference_blob); > > > > /** > > - * drm_property_unreference_blob_locked - Unreference a blob property with blob_lock held > > - * > > - * Drop a reference on a blob property. May free the object. This must be > > - * called with blob_lock held. > > - * > > - * @param dev Device the blob was created on > > - * @param blob Pointer to blob property > > - */ > > -static void drm_property_unreference_blob_locked(struct drm_property_blob *blob) > > -{ > > - if (!blob) > > - return; > > - > > - DRM_DEBUG("%p: blob ID: %d (%d)\n", blob, blob->base.id, atomic_read(&blob->refcount.refcount)); > > - > > - kref_put(&blob->refcount, drm_property_free_blob); > > -} > > - > > -/** > > * drm_property_reference_blob - Take a reference on an existing property > > * > > * Take a new reference on an existing blob property. > > -- > > 2.4.1.168.g1ea28e1 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Jani Nikula, Intel Open Source Technology Center >