From: Eduardo Habkost <ehabkost@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Michal Privoznik <mprivozn@redhat.com>,
qemu-devel@nongnu.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 1/2] pc_init1: Don't misuse int for holding up a bool
Date: Wed, 20 May 2015 09:30:11 -0300 [thread overview]
Message-ID: <20150520123011.GD28075@thinpad.lan.raisama.net> (raw)
In-Reply-To: <555C5A29.8090106@redhat.com>
On Wed, May 20, 2015 at 11:55:53AM +0200, Paolo Bonzini wrote:
> On 20/05/2015 11:15, Michal Privoznik wrote:
> > When going through code I realized, that the pc_init1() has this two
> > arguments @pci_enabled and @kvmclock_enabled which despite used as
> > booleans are of int type.
> >
> > Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>
> Eduardo, do your patches to the PC machine types subsume this change?
Yes, it replaces the int function arguments with bool globals.
(Globals that will be eventually moved to PCMachineClass with the other
8 PC compat globals we have).
--
Eduardo
next prev parent reply other threads:[~2015-05-20 12:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 9:15 [Qemu-devel] [PATCH 0/2] Couple of SMBIOS fixes Michal Privoznik
2015-05-20 9:15 ` [Qemu-devel] [PATCH 1/2] pc_init1: Don't misuse int for holding up a bool Michal Privoznik
2015-05-20 9:55 ` Paolo Bonzini
2015-05-20 12:30 ` Eduardo Habkost [this message]
2015-05-20 9:15 ` [Qemu-devel] [PATCH 2/2] SMBIOS: Allow users to chose base board type Michal Privoznik
2015-05-20 9:24 ` Paolo Bonzini
2015-05-20 12:09 ` Michal Privoznik
2015-05-20 14:16 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520123011.GD28075@thinpad.lan.raisama.net \
--to=ehabkost@redhat.com \
--cc=mprivozn@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.