Re: [PATCH] drm/i915: Force clean compilation with -Werror

[Damien Lespiau <damien.lespiau@intel.com>]

On Wed, May 20, 2015 at 11:35:28AM +0100, Chris Wilson wrote:
> Our driver compiles clean (nowadays thanks to 0day) but for me, at least,
> it would be beneficial if the compiler threw an error rather than a
> warning when it found a piece of suspect code. (I use this to
> compile-check patch series and want to break on the first compiler error
> in order to fix the patch.)
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Just to repeat what was said on IRC. -Werror is usally a no-go outside
of a development environment because different compilers (which includes
different compiler versions) will have different sets of warnings, even
with the same options. It also breaks bisecting if, for instance, or
more recent toolchain produces a warning that it didn't in a previous
version and we're trying to compile an old commit.

-- 
Damien

> ---
>  drivers/gpu/drm/i915/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index b7ddf48e1d75..5b2a6e039500 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -2,6 +2,8 @@
>  # Makefile for the drm device driver.  This driver provides support for the
>  # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher.
>  
> +subdir-ccflags-y := -Werror
> +
>  # Please keep these build lists sorted!
>  
>  # core driver code
> -- 
> 2.1.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx