From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754103AbbETRnn (ORCPT ); Wed, 20 May 2015 13:43:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36832 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754010AbbETRna (ORCPT ); Wed, 20 May 2015 13:43:30 -0400 Date: Wed, 20 May 2015 19:42:51 +0200 From: Oleg Nesterov To: Peter Zijlstra Cc: Nicholas Mc Guire , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] locking: type cleanup when accessing fast_read_ctr Message-ID: <20150520174251.GA6831@redhat.com> References: <1431971282-21412-1-git-send-email-hofrat@osadl.org> <20150519111105.GB3644@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150519111105.GB3644@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/19, Peter Zijlstra wrote: > > So the value is unsigned by purpose; that said we should never cross the > 2G I think, so it really doesn't matter much. Yes, thanks, this is on purpose. Actually I was asked to make it "unsigned" during the review, but I agree it looks better than "signed int" because of overflows. > That said; Oleg, should I post those patches implementing percpu-rwsem > with the stuff we did for the hotplug lock a while back? I think I > actually have those around somewhere. Yes, this would be nice ;) Oleg.