From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753683AbbETRpw (ORCPT <rfc822;w@1wt.eu>);
	Wed, 20 May 2015 13:45:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34981 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751996AbbETRps (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 20 May 2015 13:45:48 -0400
Date: Wed, 20 May 2015 19:44:31 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Nicholas Mc Guire <hofrat@osadl.org>, Ingo Molnar <mingo@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] locking: type cleanup when accessing fast_read_ctr
Message-ID: <20150520174431.GB6831@redhat.com>
References: <1431971282-21412-1-git-send-email-hofrat@osadl.org> <20150519111105.GB3644@twins.programming.kicks-ass.net> <20150519112513.GA1337@opentech.at>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150519112513.GA1337@opentech.at>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/19, Nicholas Mc Guire wrote:
>
> I assumed it would not matter but did not see a simple way of getting it
> type clean with unsigned either mainly due to the atomic_t being int and
> val in update_fast_ctr() being passed as -1.

Perhaps clear_fast_ctr() should have a comment to explain why it returns
"int"... even if "unsigned" should work too.

Please see https://lkml.org/lkml/2012/11/2/346

Oleg.