Re: [PATCH 02/14] IB/mad: Create an RMPP Base header

[Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]

On Wed, May 20, 2015 at 05:23:45PM -0400, ira.weiny wrote:
> On Wed, May 20, 2015 at 12:27:35PM -0600, Jason Gunthorpe wrote:
> > On Wed, May 20, 2015 at 04:13:23AM -0400, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
> > > -struct ib_rmpp_mad {
> > > +struct ib_rmpp_base {
> > >  	struct ib_mad_hdr	mad_hdr;
> > >  	struct ib_rmpp_hdr	rmpp_hdr;
> > > +} __packed;
> > > +
> > > +struct ib_rmpp_mad {
> > > +	struct ib_rmpp_base	base;
> > >  	u8			data[IB_MGMT_RMPP_DATA];
> > >  };
> > 
> > Why can't we just use:
> > 
> >  u8 data[];
> > 
> > And replace various sizeof(ib_rmpp_mad) with a rmpp_payload_size()
> > call?
> 
> I don't think it makes much difference.  I think there is just 1 place we use
> that.

There are many lines that are just churning rmpp_mad to
rmpp_base, using a flex array avoids that entirely.

Similarly patch 12 doesn't have to introduce a opa specific structure anymore.

The same sort of comment probably applies to the mad_hdr/etc as well,
but I didn't look very closely.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html