From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH 1/3] git-verify-pack.txt: fix inconsistent spelling of "packfile"
Date: Wed, 20 May 2015 22:04:03 -0400 [thread overview]
Message-ID: <20150521020402.GA11619@peff.net> (raw)
In-Reply-To: <xmqqzj4ylvto.fsf@gitster.dls.corp.google.com>
On Wed, May 20, 2015 at 03:37:23PM -0700, Junio C Hamano wrote:
> In any case, even though I merged these three to 'next', I think we
> need to either revert 3/3 or do s/pack-file/packfile/ throughout the
> pack-protocol documentation. The original has something like this:
>
> The pack-file MUST NOT be sent if the only command used is 'delete'.
>
> A pack-file MUST be sent if either create or update command is used,
> even if the server already has all the necessary objects. In this
> case the client MUST send an empty pack-file. The only time this
> is likely to happen is if the client is creating
> a new branch or a tag that points to an existing obj-id.
>
> and these are explicitly referring to what EBNF defines as "pack-file".
> Changing them to "packfile" is simply wrong.
Yeah, I agree they should agree with the EBNF. And my inclination is for
"packfile", as it is refering to the concept of the on-the-wire packfile
data (there is no "file ending in .pack" in this context).
Which I guess argues for a further patch.
-Peff
next prev parent reply other threads:[~2015-05-21 2:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-17 6:56 [PATCH 1/3] git-verify-pack.txt: fix inconsistent spelling of "packfile" Patrick Steinhardt
2015-05-17 6:56 ` [PATCH 2/3] git-unpack-objects.txt: " Patrick Steinhardt
2015-05-17 6:56 ` [PATCH 3/3] pack-protocol.txt: fix insconsistent " Patrick Steinhardt
2015-05-19 19:34 ` [PATCH 1/3] git-verify-pack.txt: fix inconsistent " Junio C Hamano
2015-05-19 22:24 ` Jeff King
2015-05-20 19:22 ` Junio C Hamano
2015-05-20 19:45 ` Junio C Hamano
2015-05-20 19:49 ` Jeff King
2015-05-20 22:37 ` Junio C Hamano
2015-05-21 2:04 ` Jeff King [this message]
2015-05-21 4:54 ` Junio C Hamano
2015-05-21 7:27 ` [PATCH] doc: " Patrick Steinhardt
2015-05-21 16:37 ` Junio C Hamano
2015-05-22 6:10 ` Patrick Steinhardt
2015-05-22 6:22 ` [PATCH v2] " Patrick Steinhardt
2015-05-22 16:00 ` Junio C Hamano
2015-05-20 5:13 ` [PATCH 1/3] git-verify-pack.txt: " Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521020402.GA11619@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.