From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
fw@strlen.de, David Miller <davem@davemloft.net>
Subject: Re: netfilter: ensure number of counters is >0 in do_replace()
Date: Thu, 21 May 2015 13:42:03 +0200 [thread overview]
Message-ID: <20150521114203.GA5353@salvia> (raw)
In-Reply-To: <20150520005517.GA7998@codemonkey.org.uk>
On Tue, May 19, 2015 at 08:55:17PM -0400, Dave Jones wrote:
> After improving setsockopt() coverage in trinity, I started triggering
> vmalloc failures pretty reliably from this code path:
>
> warn_alloc_failed+0xe9/0x140
> __vmalloc_node_range+0x1be/0x270
> vzalloc+0x4b/0x50
> __do_replace+0x52/0x260 [ip_tables]
> do_ipt_set_ctl+0x15d/0x1d0 [ip_tables]
> nf_setsockopt+0x65/0x90
> ip_setsockopt+0x61/0xa0
> raw_setsockopt+0x16/0x60
> sock_common_setsockopt+0x14/0x20
> SyS_setsockopt+0x71/0xd0
>
> It turns out we don't validate that the num_counters field in the
> struct we pass in from userspace is initialized.
>
> The same problem also exists in ebtables, arptables, ipv6, and the
> compat variants.
Applied.
This also applies to -stable kernels:
3.2.x
3.4.x
3.10.x
3.12.x
3.14.x
3.18.x
4.0.x
so after some testing and a little while, I'll pass this on.
Thanks.
prev parent reply other threads:[~2015-05-21 11:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 23:11 iptables: ensure number of counters is >0 in do_replace() Dave Jones
2015-05-19 23:19 ` Florian Westphal
2015-05-19 23:42 ` Dave Jones
2015-05-20 0:20 ` David Miller
2015-05-20 0:55 ` netfilter: " Dave Jones
2015-05-21 11:42 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521114203.GA5353@salvia \
--to=pablo@netfilter.org \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.