Re: [RFC/RFT v2 0/2] power_supply: Fix NULL pointer dereference from uevent

[Sebastian Reichel <sre@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

Hi,

On Tue, May 19, 2015 at 04:13:00PM +0900, Krzysztof Kozlowski wrote:
> Changes since v1:
> =================
> 1. Patch 2: fix invalid member used for container_of().
> 2. Patch 2: Replace WARN with pr_warn() in __power_supply_register()
>    if parent is missing.
> 
> 
> Description:
> ============
> This is an idea to fix issue in bq27x00 driver (and probably in others)
> reported by H. Nikolaus Schaller [0].
> 
> The fixes are marked RFC/RFT because:
> 1. I do not have bq27x00-like device. I confirmed this and tested on
>    modified drivers (max77693, ACPI AC). These drivers are not
>    impacted by the issue but one can easily adjust them to reproduce
>    the problem.
> 2. The first uevent coming from power_supply_register() is now
>    different because it won't contain device properties. I am
>    not sure how this impacts userspace.
> 
> Comments are welcomed.

Queued to for-next and fixes. I will not sent it to Torvalds before
Sunday, so that it gets some testing in next.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]