From: "Pali Rohár" <pali.rohar@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: Compile errors with dell_rbtn_notifier_register
Date: Thu, 21 May 2015 22:59:28 +0200 [thread overview]
Message-ID: <201505212259.29035@pali> (raw)
In-Reply-To: <56482.1432241617@turing-police.cc.vt.edu>
[-- Attachment #1: Type: Text/Plain, Size: 1191 bytes --]
On Thursday 21 May 2015 22:53:37 Valdis Kletnieks wrote:
> commit 61104aa44529d59bd01a5d51df571ca2823a04b3
> Author: Pali Rohár <pali.rohar@gmail.com>
> Date: Thu May 14 12:54:27 2015 +0200
>
> dell-laptop: Use dell-rbtn instead i8042 filter when possible
>
> causes build errors:
>
> LD init/built-in.o
> drivers/built-in.o: In function `dell_init':
> /usr/src/linux-next/drivers/platform/x86/dell-laptop.c:762: undefined
> reference to `dell_rbtn_notifier_register'
> /usr/src/linux-next/drivers/platform/x86/dell-laptop.c:2016:
> undefined reference to `dell_rbtn_notifier_unregister'
> drivers/built-in.o: In function `dell_exit':
> /usr/src/linux-next/drivers/platform/x86/dell-laptop.c:2041:
> undefined reference to `dell_rbtn_notifier_unregister'
>
> when built with:
>
> CONFIG_DELL_LAPTOP=y
> CONFIG_DELL_RBTN=m
>
> because the builtin then references a symbol that's in a module.
>
> Probably needs some Kconfig magic to ensure this case doesn't happen.
Darren, what do you prefer as fix? Some Kconfig magic (maybe depends?)?
or other magic in dell_rbtn.h to inline empty functions?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2015-05-21 20:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 20:53 Compile errors with dell_rbtn_notifier_register Valdis Kletnieks
2015-05-21 20:59 ` Pali Rohár [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201505212259.29035@pali \
--to=pali.rohar@gmail.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.