From: bp@alien8.de (Borislav Petkov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 4/5] edac: Add APM X-Gene SoC EDAC driver
Date: Fri, 22 May 2015 10:46:25 +0200 [thread overview]
Message-ID: <20150522084625.GE23022@pd.tnic> (raw)
In-Reply-To: <4456746.y9FVaqRogk@wuerfel>
On Fri, May 22, 2015 at 10:23:11AM +0200, Arnd Bergmann wrote:
> > +static int edac_mc_idx;
> > +static int edac_mc_active_mask;
> > +static int edac_mc_registered_mask;
> > +static DEFINE_MUTEX(xgene_edac_mc_lock);
>
> It would also be best to avoid global variables, but it seems that at
> least the edac_mc_idx is needed to work with the EDAC subsystem.
> Maybe Boris has an idea for how to avoid it.
Right, so AFAICT this is used in
edac_mc_alloc(edac_mc_idx++
and basically we're supplying the memory controller numbers in the order
we're calling xgene_edac_mc_add(). Perhaps we need to make the memory
controller numbering explicit with DT...
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Loc Ho <lho-qTEPVZfXA3Y@public.gmane.org>,
dougthompson-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
patches-qTEPVZfXA3Y@public.gmane.org
Subject: Re: [PATCH v10 4/5] edac: Add APM X-Gene SoC EDAC driver
Date: Fri, 22 May 2015 10:46:25 +0200 [thread overview]
Message-ID: <20150522084625.GE23022@pd.tnic> (raw)
In-Reply-To: <4456746.y9FVaqRogk@wuerfel>
On Fri, May 22, 2015 at 10:23:11AM +0200, Arnd Bergmann wrote:
> > +static int edac_mc_idx;
> > +static int edac_mc_active_mask;
> > +static int edac_mc_registered_mask;
> > +static DEFINE_MUTEX(xgene_edac_mc_lock);
>
> It would also be best to avoid global variables, but it seems that at
> least the edac_mc_idx is needed to work with the EDAC subsystem.
> Maybe Boris has an idea for how to avoid it.
Right, so AFAICT this is used in
edac_mc_alloc(edac_mc_idx++
and basically we're supplying the memory controller numbers in the order
we're calling xgene_edac_mc_add(). Perhaps we need to make the memory
controller numbering explicit with DT...
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-22 8:46 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 23:24 [PATCH v10 0/4] edac: Add APM X-Gene SoC EDAC driver Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-18 23:24 ` [PATCH v10 1/5] arm64: Enable EDAC on ARM64 Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-18 23:24 ` [PATCH v10 2/5] MAINTAINERS: Add entry for APM X-Gene SoC EDAC driver Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-18 23:24 ` [PATCH v10 3/5] Documentation: Add documentation for the APM X-Gene SoC EDAC DTS binding Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-18 23:24 ` [PATCH v10 4/5] edac: Add APM X-Gene SoC EDAC driver Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-18 23:24 ` [PATCH v10 5/5] arm64: Add APM X-Gene SoC EDAC DTS entries Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-22 8:23 ` [PATCH v10 4/5] edac: Add APM X-Gene SoC EDAC driver Arnd Bergmann
2015-05-22 8:23 ` Arnd Bergmann
2015-05-22 8:46 ` Borislav Petkov [this message]
2015-05-22 8:46 ` Borislav Petkov
2015-05-22 8:55 ` Arnd Bergmann
2015-05-22 8:55 ` Arnd Bergmann
2015-05-22 18:28 ` Loc Ho
2015-05-22 18:28 ` Loc Ho
2015-05-22 18:25 ` Loc Ho
2015-05-22 18:25 ` Loc Ho
2015-05-22 8:59 ` Arnd Bergmann
2015-05-22 8:59 ` Arnd Bergmann
2015-05-22 8:02 ` [PATCH v10 3/5] Documentation: Add documentation for the APM X-Gene SoC EDAC DTS binding Arnd Bergmann
2015-05-22 8:02 ` Arnd Bergmann
2015-05-19 17:03 ` [PATCH v10 1/5] arm64: Enable EDAC on ARM64 Borislav Petkov
2015-05-19 17:03 ` Borislav Petkov
2015-05-19 19:57 ` Loc Ho
2015-05-19 19:57 ` Loc Ho
2015-05-19 20:33 ` Borislav Petkov
2015-05-19 20:33 ` Borislav Petkov
2015-05-21 18:07 ` Borislav Petkov
2015-05-21 18:07 ` Borislav Petkov
2015-05-21 18:11 ` [RFC PATCH] EDAC: Cleanup atomic_scrub mess Borislav Petkov
2015-05-21 18:11 ` Borislav Petkov
2015-05-22 20:13 ` Chris Metcalf
2015-05-22 20:13 ` Chris Metcalf
2015-05-27 15:52 ` Borislav Petkov
2015-05-27 15:52 ` Borislav Petkov
2015-05-28 2:27 ` Michael Ellerman
2015-05-28 2:27 ` Michael Ellerman
2015-05-28 12:34 ` Russell King - ARM Linux
2015-05-28 12:34 ` Russell King - ARM Linux
2015-05-28 13:37 ` Borislav Petkov
2015-05-28 13:37 ` Borislav Petkov
2015-05-22 8:24 ` [PATCH v10 0/4] edac: Add APM X-Gene SoC EDAC driver Arnd Bergmann
2015-05-22 8:24 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150522084625.GE23022@pd.tnic \
--to=bp@alien8.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.