Re: [PATCH] tty: serial: omap: use mctrl_gpio helpers

[Tony Lindgren <tony@atomide.com>]

* Nishanth Menon <nm@ti.com> [150522 08:36]:
> On 05/22/2015 07:16 AM, yegorslists@googlemail.com wrote:
> > From: Yegor Yefremov <yegorslists@googlemail.com>
> > 
> > This patch permits to use GPIOs to control the CTS/RTS/DTR/DSR/DCD/RI
> > signals.
> > 
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> > ---
> >  .../devicetree/bindings/serial/omap_serial.txt     |    9 +
> >  drivers/tty/serial/Kconfig                         |    1 +
> >  drivers/tty/serial/omap-serial.c                   |  168 +++++++++++++++++++-
> >  3 files changed, 171 insertions(+), 7 deletions(-)
> 
> Would we rather move introducing new features to 8250_omap.c rather
> than doing that to omap-serial and keep feature creeping it such that
> we wont ever be able to switch to 8250_omap ?

Yes please. Also, do we really want to allow mapping
random GPIO pins to the UART driver? I guess it would be
handy for powering UART connected devices like BT up
and down..

There's one fix pending to 8250_omap for mainline BTW:

[PATCH] serial: 8250_omap: provide complete custom startup & shutdown callbacks

But other than that it seems to behave at least for me.

Regards,

Tony