From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] tty: serial: omap: use mctrl_gpio helpers Date: Fri, 22 May 2015 10:54:30 -0700 Message-ID: <20150522175429.GB10274@atomide.com> References: <1432297017-1264-1-git-send-email-yegorslists@googlemail.com> <555F4C7F.9020307@ti.com> <20150522165212.GZ10274@atomide.com> <20150522173816.GE5582@saruman.tx.rr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from muru.com ([72.249.23.125]:53063 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757003AbbEVRyd (ORCPT ); Fri, 22 May 2015 13:54:33 -0400 Content-Disposition: inline In-Reply-To: <20150522173816.GE5582@saruman.tx.rr.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: Nishanth Menon , yegorslists@googlemail.com, linux-serial@vger.kernel.org, linux-omap@vger.kernel.org, gregkh@linuxfoundation.org, Sebastian Andrzej Siewior , Sekhar Nori * Felipe Balbi [150522 10:41]: > On Fri, May 22, 2015 at 09:52:13AM -0700, Tony Lindgren wrote: > > * Nishanth Menon [150522 08:36]: > > > On 05/22/2015 07:16 AM, yegorslists@googlemail.com wrote: > > > > From: Yegor Yefremov > > > > > > > > This patch permits to use GPIOs to control the CTS/RTS/DTR/DSR/DCD/RI > > > > signals. > > > > > > > > Signed-off-by: Yegor Yefremov > > > > --- > > > > .../devicetree/bindings/serial/omap_serial.txt | 9 + > > > > drivers/tty/serial/Kconfig | 1 + > > > > drivers/tty/serial/omap-serial.c | 168 +++++++++++++++++++- > > > > 3 files changed, 171 insertions(+), 7 deletions(-) > > > > > > Would we rather move introducing new features to 8250_omap.c rather > > > than doing that to omap-serial and keep feature creeping it such that > > > we wont ever be able to switch to 8250_omap ? > > > > Yes please. Also, do we really want to allow mapping > > random GPIO pins to the UART driver? I guess it would be > > See drivers/tty/serial/serial_mctrl_gpio.[ch], these are used for UARTs > on SoCs with enough GPIOs available whose UART don't have full Modem > signals. It's pretty handy for BT, GSM, LTE, whatever type of modem-like > device. OK Tony