All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Tejun Heo <tj@kernel.org>,
	lizefan@huawei.com, cgroups@vger.kernel.org, hannes@cmpxchg.org,
	linux-mm@kvack.org
Subject: [PATCH 3/3] memcg: change mm_update_next_owner() to search in sub-threads first
Date: Fri, 22 May 2015 20:21:51 +0200	[thread overview]
Message-ID: <20150522182151.GD26770@redhat.com> (raw)
In-Reply-To: <20150522182054.GA26770@redhat.com>

mm_update_next_owner() checks the children and siblings to avoid
the "global" for_each_process() loop. Not sure this makes any sense,
but certainly it makes sense to check our sub-threads before anything
else.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
 kernel/exit.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/kernel/exit.c b/kernel/exit.c
index 1d1810d..b1f7135 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -340,6 +340,12 @@ void mm_update_next_owner(struct mm_struct *mm)
 
 	read_lock(&tasklist_lock);
 	/*
+	 * Search in the sub-threads
+	 */
+	if (assign_new_owner(mm, p))
+		goto done;
+
+	/*
 	 * Search in the children
 	 */
 	list_for_each_entry(g, &p->children, sibling) {
@@ -359,7 +365,7 @@ void mm_update_next_owner(struct mm_struct *mm)
 	 * Search through everything else, we should not get here often.
 	 */
 	for_each_process(g) {
-		if (g->flags & PF_KTHREAD)
+		if (g == p || g->flags & PF_KTHREAD)
 			continue;
 		if (assign_new_owner(mm, g))
 			goto done;
-- 
1.5.5.1


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2015-05-22 18:21 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18 19:49 [PATCHSET cgroup/for-4.2] cgroup: make multi-process migration atomic Tejun Heo
2015-05-18 19:49 ` Tejun Heo
     [not found] ` <1431978595-12176-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-05-18 19:49   ` [PATCH 1/7] cpuset: migrate memory only for threadgroup leaders Tejun Heo
2015-05-18 19:49     ` Tejun Heo
2015-05-18 19:49   ` [PATCH 2/7] memcg: restructure mem_cgroup_can_attach() Tejun Heo
2015-05-18 19:49     ` Tejun Heo
     [not found]     ` <1431978595-12176-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-05-19  9:03       ` Michal Hocko
2015-05-19  9:03         ` Michal Hocko
2015-05-18 19:49   ` [PATCH 3/7] memcg: immigrate charges only when a threadgroup leader is moved Tejun Heo
2015-05-18 19:49     ` Tejun Heo
     [not found]     ` <1431978595-12176-4-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-05-19 12:13       ` Michal Hocko
2015-05-19 12:13         ` Michal Hocko
     [not found]         ` <20150519121321.GB6203-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-05-19 13:10           ` Michal Hocko
2015-05-19 13:10             ` Michal Hocko
2015-05-19 21:27           ` Tejun Heo
2015-05-19 21:27             ` Tejun Heo
2015-05-20 13:10             ` Michal Hocko
2015-05-20 13:21               ` Michal Hocko
     [not found]                 ` <20150520132158.GB28678-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-05-20 17:53                   ` Oleg Nesterov
2015-05-20 17:53                     ` Oleg Nesterov
2015-05-20 20:22                     ` Michal Hocko
2015-05-20 20:22                       ` Michal Hocko
     [not found]                       ` <20150520202221.GD14256-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-05-21 17:22                         ` Johannes Weiner
2015-05-21 17:22                           ` Johannes Weiner
2015-05-22  9:34                           ` Michal Hocko
2015-05-21 19:27                         ` Oleg Nesterov
2015-05-21 19:27                           ` Oleg Nesterov
     [not found]                           ` <20150521192716.GA21304-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-22  9:36                             ` Michal Hocko
2015-05-22  9:36                               ` Michal Hocko
     [not found]                               ` <20150522093639.GE5109-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-05-22 16:29                                 ` Oleg Nesterov
2015-05-22 16:29                                   ` Oleg Nesterov
2015-05-22 16:57                                   ` Michal Hocko
2015-05-22 18:30                                     ` Oleg Nesterov
     [not found]                                       ` <20150522183042.GF26770-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-25 16:06                                         ` Michal Hocko
2015-05-25 16:06                                           ` Michal Hocko
     [not found]                                           ` <20150525160626.GC19389-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-05-25 17:06                                             ` Oleg Nesterov
2015-05-25 17:06                                               ` Oleg Nesterov
     [not found]                                               ` <20150525170601.GA438-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-26  7:16                                                 ` Michal Hocko
2015-05-26  7:16                                                   ` Michal Hocko
2015-05-22 18:20                                   ` [PATCH 0/3] memcg: mm_update_next_owner() cleanups Oleg Nesterov
     [not found]                                     ` <20150522182054.GA26770-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-22 18:21                                       ` [PATCH 1/3] memcg: introduce assign_new_owner() Oleg Nesterov
2015-05-22 18:21                                         ` Oleg Nesterov
2015-05-22 18:21                                       ` [PATCH 2/3] memcg: change assign_new_owner() to consider the sub-htreads Oleg Nesterov
2015-05-22 18:21                                         ` Oleg Nesterov
2015-05-22 18:21                                     ` Oleg Nesterov [this message]
2015-05-22 18:22                                     ` [PATCH 0/3] memcg: mm_update_next_owner() cleanups Oleg Nesterov
2015-05-21 14:12       ` [PATCH 3/7] memcg: immigrate charges only when a threadgroup leader is moved Michal Hocko
2015-05-21 14:12         ` Michal Hocko
     [not found]         ` <20150521141225.GB14475-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-05-21 22:09           ` Tejun Heo
2015-05-21 22:09             ` Tejun Heo
2015-05-18 19:49   ` [PATCH 4/7] cgroup, memcg, cpuset: implement cgroup_taskset_for_each_leader() Tejun Heo
2015-05-18 19:49     ` Tejun Heo
2015-05-18 19:49   ` [PATCH 5/7] reorder cgroup_migrate()'s parameters Tejun Heo
2015-05-18 19:49     ` Tejun Heo
2015-05-18 19:49   ` [PATCH 6/7] cgroup: separate out taskset operations from cgroup_migrate() Tejun Heo
2015-05-18 19:49     ` Tejun Heo
2015-05-18 19:49   ` [PATCH 7/7] cgroup: make cgroup_update_dfl_csses() migrate all target processes atomically Tejun Heo
2015-05-18 19:49     ` Tejun Heo
2015-05-19  6:57 ` [PATCHSET cgroup/for-4.2] cgroup: make multi-process migration atomic Zefan Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150522182151.GD26770@redhat.com \
    --to=oleg@redhat.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan@huawei.com \
    --cc=mhocko@suse.cz \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.